Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio fix: #593

Merged
merged 2 commits into from
Sep 6, 2018
Merged

audio fix: #593

merged 2 commits into from
Sep 6, 2018

Conversation

ikreymer
Copy link
Collaborator

  • migrate latest version of browser_controller.js from shepherd to frontend
  • trigger audio init on first click to avoid browser autoplay block

- migrate latest version of browser_controller.js from shepherd to frontend
- trigger audio init on first click to avoid browser autoplay block
@ikreymer ikreymer requested a review from m4rk3r August 15, 2018 00:22
@codecov
Copy link

codecov bot commented Aug 15, 2018

Codecov Report

Merging #593 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #593   +/-   ##
========================================
  Coverage    74.31%   74.31%           
========================================
  Files           61       61           
  Lines         7402     7402           
  Branches      1129     1129           
========================================
  Hits          5501     5501           
  Misses        1531     1531           
  Partials       370      370

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e53a439...8b72925. Read the comment docs.

@ikreymer ikreymer merged commit c1080ff into develop Sep 6, 2018
@ikreymer ikreymer deleted the audio-fix branch September 6, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant