Skip to content

Commit

Permalink
Various language, typos, trailing charactes and small details fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
PoTe committed Jan 14, 2012
1 parent 269af9d commit ee4ae13
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
20 changes: 10 additions & 10 deletions CONTRIBUTE
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -18,19 +18,19 @@ Coding standards
.Formatting .Formatting


Go is simple and straightforward enough to avoid code mess. Although, Go is simple and straightforward enough to avoid code mess. Although,
you should always check your code formating with 'gofmt' tool. you should always check your code formating with the 'gofmt' tool.


.Testing .Testing


If you implemented new feature, then appropriate tests should be If you are implementing a new feature, please write the appropriate tests
added to prove its proper functionality. Remember to always check if to prove its proper functionality. Remember to always check that all the
all tests are passing before you submit your changes. Use `make check` tests are passing before you submit your changes. Use the `make check`
command to run our test suite. command to run our test suite.


.Documentation .Documentation


All new types and functions added to the code should be documented. All new types and functions added to the code should be documented.
Good documentation makes our and your life much esier. Good documentation makes your life and ours much easier.


Submitting Patches Submitting Patches
------------------ ------------------
Expand All @@ -44,8 +44,8 @@ revise your patch, send it as a followup to the initial topic.


.Description .Description


For bug fixes, a description of the bug and how your patch fixes thisbug. Bug fixes must include a description of the bug and how your patch fixes it.
For new features, a description of the feature and your implementation. New features must include a description of the feature and your implementation.


.ChangeLog .ChangeLog


Expand All @@ -57,8 +57,8 @@ documentation, i.e. txt files in the 'docs' directory.


.The patch itself .The patch itself


Please, reread your patch's diff before you submit it. Use `git diff` command Please, reread your patch's diff before you submit it. Use the `git diff` command
to review it. to review it.


.Do not mix changes .Do not mix changes


Expand Down
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Original file line Diff line number Diff line change
@@ -1,3 +1,7 @@
2012-01-14 Pablo Astigarraga <pote@tardis.com.uy>

* CONTRIBUTE: Various language nipticks.

2012-01-12 Krzysztof Kowalik <chris@nu7hat.ch> 2012-01-12 Krzysztof Kowalik <chris@nu7hat.ch>


* webrocket-admin/: added list_workers option * webrocket-admin/: added list_workers option
Expand Down

0 comments on commit ee4ae13

Please sign in to comment.