Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Build errors on windows on version v0.10.0 #190

Closed
pieter-lazzaro opened this issue Jan 30, 2023 · 3 comments
Closed

Bug: Build errors on windows on version v0.10.0 #190

pieter-lazzaro opened this issue Jan 30, 2023 · 3 comments

Comments

@pieter-lazzaro
Copy link
Contributor

When trying to generate a file on windows I get the following error:

failed to parse ./proto/service.ridl:failed to read file: open :\Users\piete\Repositories\dataflex\proto\service.ridl: invalid argument

It looks like the DirFS that is used is not cross-platform compatible (golang/go#44279)

It can be easily fixed for my use case by checking for a volume and using that as a base. I can create a PR for that. However more careful consideration might be needed depending on what supported scenarios there are.

@VojtechVitek
Copy link
Contributor

Hi @pieter-lazzaro, what do you propose as a fix?

@pieter-lazzaro
Copy link
Contributor Author

Hi @VojtechVitek,

The fix that I did was to check if filepath.VolumeName returns anything and if it does use that as the root path.

I have created PR #202

@VojtechVitek
Copy link
Contributor

I think this was fixed in #202. Please reopen if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants