Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples after introducing customer webrpc errors #209

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

LukasJenicek
Copy link
Contributor

@LukasJenicek LukasJenicek commented Jun 9, 2023

After introducing the custom webrpc errors the examples stopped working, because they were still using the old predefined errors which don't exist in latest webrpc-gen version

@LukasJenicek LukasJenicek changed the title Fix undefined error in examples by defining custom error when user is not found Fix examples after introducing customer webrpc errors Jun 9, 2023
@LukasJenicek LukasJenicek mentioned this pull request Jun 9, 2023
generate:
webrpc-gen -schema=example.webrpc.json -target=golang -pkg=main -server -out=./server/server.gen.go
webrpc-gen -schema=example.webrpc.json -target=javascript -client -out=./client/client.gen.mjs

run-server:
go run ./server
go run lsserver/cmd/api.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lsserver, is this a typo?

Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small typo

@VojtechVitek VojtechVitek merged commit ed201f3 into master Jun 13, 2023
4 checks passed
@VojtechVitek VojtechVitek deleted the fix_examples branch June 13, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants