Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get all required fields #253

Merged
merged 1 commit into from
Mar 5, 2024
Merged

get all required fields #253

merged 1 commit into from
Mar 5, 2024

Conversation

LukasJenicek
Copy link
Contributor

No description provided.

@LukasJenicek LukasJenicek force-pushed the required_field branch 2 times, most recently from 2026482 to bbeee94 Compare March 4, 2024 15:10
@LukasJenicek LukasJenicek changed the title add func to find if type has at least one required field get all required fields Mar 4, 2024
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkieltyka
Copy link
Member

LGTM too -- what will we use this for btw?

@LukasJenicek
Copy link
Contributor Author

@pkieltyka here: webrpc/gen-openapi#14

I need to get if at least one field is required, because required attribute without any fields was causing redocly to fail render the openapi document.

@pkieltyka
Copy link
Member

nice :) I thought so.. lets merge it as you're ready

@LukasJenicek LukasJenicek merged commit 8797f91 into master Mar 5, 2024
4 checks passed
@LukasJenicek LukasJenicek deleted the required_field branch March 5, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants