Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export rtcp/rtp/interceptor/data/media #125

Merged
merged 4 commits into from
Oct 25, 2021

Conversation

wdv4758h
Copy link
Contributor

I'm building SFU based on WebRTC.rs. And I feel adding related dependencies in my Cargo.toml is a bit inconvenient. There is potential of version mismatch problem. So I think re-export dependencies under webrtc crate might help. (not sure if I should re-export all of them though)

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #125 (ad6dc98) into master (aac2e56) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   57.67%   57.70%   +0.03%     
==========================================
  Files          68       68              
  Lines        5533     5533              
  Branches     1696     1698       +2     
==========================================
+ Hits         3191     3193       +2     
+ Misses        855      854       -1     
+ Partials     1487     1486       -1     
Impacted Files Coverage Δ
src/lib.rs 100.00% <ø> (ø)
...c/peer/peer_connection/peer_connection_internal.rs 49.11% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac2e56...ad6dc98. Read the comment docs.

@@ -12,6 +12,9 @@ pub mod stats;
pub mod util;

pub use error::Error;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to examples’ Cargo.toml, let’s re-export data and media too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍

@wdv4758h
Copy link
Contributor Author

There are name confict for data and media (there are modules with same name). Not sure what's the convention under this circumstances. I add _ prefix for now.

@wdv4758h wdv4758h changed the title re-export rtcp/rtp/interceptor re-export rtcp/rtp/interceptor/data/media Oct 25, 2021
src/lib.rs Outdated
@@ -11,7 +11,12 @@ pub mod peer;
pub mod stats;
pub mod util;

pub use ::data as _data;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use webrtc_data and webrtc_media?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rainliu
Copy link
Member

rainliu commented Oct 25, 2021

can these re-export solve version mismatch issue? Have you tried it in examples crate?

@wdv4758h
Copy link
Contributor Author

yep, this will reduce the manually version tagging for subcrates.
I have a local build with examples crate, the change is here for now: wdv4758h/webrtc-examples@7da1d57
I didn't run the binary, but I can compile all the examples with the update patch.

@rainliu rainliu merged commit 672a932 into webrtc-rs:master Oct 25, 2021
@rainliu
Copy link
Member

rainliu commented Oct 25, 2021

yep, this will reduce the manually version tagging for subcrates. I have a local build with examples crate, the change is here for now: wdv4758h/webrtc-examples@7da1d57 I didn't run the binary, but I can compile all the examples with the update patch.

@wdv4758h, I just upgrade webrtc crate to v0.2.2 with this PR. Could you submit a PR for examples crate with this change?

@wdv4758h
Copy link
Contributor Author

yep, this will reduce the manually version tagging for subcrates. I have a local build with examples crate, the change is here for now: wdv4758h/webrtc-examples@7da1d57 I didn't run the binary, but I can compile all the examples with the update patch.

@wdv4758h, I just upgrade webrtc crate to v0.2.2 with this PR. Could you submit a PR for examples crate with this change?

yep

@wdv4758h wdv4758h deleted the re-export branch October 25, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants