Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start/Stop receiving stream method for VideoTrack #25

Merged
merged 8 commits into from
May 10, 2022

Conversation

davidliu
Copy link
Contributor

@davidliu davidliu commented May 9, 2022

Used to mitigate decoder limitations (android crashes if there are too many decoders, iOS freezes up).

@hiroshihorie
Copy link
Member

Wow, would like to try this out !

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work! This is a huge deal 🔥

@davidliu davidliu merged commit 415fbe5 into m97_release May 10, 2022
@davidliu davidliu deleted the dl/stop_decoder branch May 10, 2022 12:32
davidliu added a commit that referenced this pull request Jul 17, 2022
* Initial implementation of start/stop receive

* move set_state call to signalling thread as well.

https://source.chromium.org/chromium/_/webrtc/src.git/+/dfd69c22100e1d2e83295f33d06fa9916caa5c53

* separate should_receive from enabled for now

* ios hooks

* Fix ios compile errors

* code cleanup

* clean up

* reuse frame buffers instead
davidliu added a commit that referenced this pull request Jul 21, 2022
* Initial implementation of start/stop receive

* move set_state call to signalling thread as well.

https://source.chromium.org/chromium/_/webrtc/src.git/+/dfd69c22100e1d2e83295f33d06fa9916caa5c53

* separate should_receive from enabled for now

* ios hooks

* Fix ios compile errors

* code cleanup

* clean up

* reuse frame buffers instead
cloudwebrtc pushed a commit that referenced this pull request Jan 18, 2023
* Initial implementation of start/stop receive

* move set_state call to signalling thread as well.

https://source.chromium.org/chromium/_/webrtc/src.git/+/dfd69c22100e1d2e83295f33d06fa9916caa5c53

* separate should_receive from enabled for now

* ios hooks

* Fix ios compile errors

* code cleanup

* clean up

* reuse frame buffers instead
cloudwebrtc pushed a commit that referenced this pull request Jun 5, 2023
* Initial implementation of start/stop receive

* move set_state call to signalling thread as well.

https://source.chromium.org/chromium/_/webrtc/src.git/+/dfd69c22100e1d2e83295f33d06fa9916caa5c53

* separate should_receive from enabled for now

* ios hooks

* Fix ios compile errors

* code cleanup

* clean up

* reuse frame buffers instead
cloudwebrtc pushed a commit that referenced this pull request Jun 12, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

Co-authored-by: davidliu <davidliu@deviange.net>
@cloudwebrtc cloudwebrtc mentioned this pull request Jun 12, 2023
cloudwebrtc pushed a commit that referenced this pull request Jun 12, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

Co-authored-by: davidliu <davidliu@deviange.net>
cloudwebrtc pushed a commit that referenced this pull request Jun 12, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Co-authored-by: davidliu <davidliu@deviange.net>
cloudwebrtc pushed a commit that referenced this pull request Jul 12, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Co-authored-by: davidliu <davidliu@deviange.net>
cloudwebrtc pushed a commit that referenced this pull request Jul 13, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Co-authored-by: davidliu <davidliu@deviange.net>
cloudwebrtc pushed a commit that referenced this pull request Jul 13, 2023
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Exposing Adapter types in PeerConnectionFactory (#78)

Co-authored-by: davidliu <davidliu@deviange.net>
Co-authored-by: Mohamed Risaldar UT <73091075+MohamedRisaldarTA@users.noreply.github.com>
cloudwebrtc pushed a commit that referenced this pull request May 22, 2024
Start/Stop receiving stream method for VideoTrack (#25)

Properly remove observer upon deconstruction (#26)

feat: Expose setCodecPreferences/getCapabilities for android. (#61)

fix: add WrappedVideoDecoderFactory.java. (#74)

Co-authored-by: davidliu <davidliu@deviange.net>
@cloudwebrtc cloudwebrtc mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants