Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of RTCRtpScriptTransform if available. #1468

Merged

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Aug 17, 2021

Use VP8 by default as it works best with encryption transforms.

Fixes #1467

Use VP8 by default as it works best with encryption transforms.
@google-cla google-cla bot added the cla: yes label Aug 17, 2021
@youennf
Copy link
Contributor Author

youennf commented Aug 17, 2021

@fippo,PTAL.

@youennf
Copy link
Contributor Author

youennf commented Aug 17, 2021

Interestingly, the JS encryption code seems to run much faster on Chrome than STP. This might require some investigations on Safari side. I filed https://bugs.webkit.org/show_bug.cgi?id=229190 to keep track of it.

@youennf
Copy link
Contributor Author

youennf commented Aug 17, 2021

linter does not like 'new RTCRtpScriptTransform', not sure what is the best way to address this. Any idea?

@fippo
Copy link
Collaborator

fippo commented Aug 17, 2021

/* global RTCRtpScriptTransform */ at the top of the file should help. There is a followup to teach eslint about this but I never figured out who adds new globals to it.

I'll defer to @alvestrand for review

@youennf
Copy link
Contributor Author

youennf commented Aug 19, 2021

Thanks @fippo, linter is good now.
@alvestrand PTAL.

Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice illustration of the relatively small differences between the approaches when you have decided to use a worker.

No big comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update end-to-end example to be able to run it in Safari Technology Preview
4 participants