-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of RTCRtpScriptTransform if available. #1468
Make use of RTCRtpScriptTransform if available. #1468
Conversation
Use VP8 by default as it works best with encryption transforms.
@fippo,PTAL. |
Interestingly, the JS encryption code seems to run much faster on Chrome than STP. This might require some investigations on Safari side. I filed https://bugs.webkit.org/show_bug.cgi?id=229190 to keep track of it. |
linter does not like 'new RTCRtpScriptTransform', not sure what is the best way to address this. Any idea? |
I'll defer to @alvestrand for review |
Thanks @fippo, linter is good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice illustration of the relatively small differences between the approaches when you have decided to use a worker.
No big comments.
Use VP8 by default as it works best with encryption transforms.
Fixes #1467