Updating to nodejs 12 and fixing build #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like gh-pages is ignored by travis however I found: travis-ci/travis-core#137. Trying it to see if it works.
|
@samdutton YAY, the build is up and running again ;) |
|
But it's still failing the build, but at least the build is running automatically now on the gh-pages branch. Will look into the webdriver issue. |
|
Excellent!
Yes... |
|
To be clear, it works locally when using a locally compiled Node 4.2.1 version, not sure how that maps to the 0.12.x versions etc. |
|
Parts of Travis is down :( Will check this later. |
|
Merging to get a green build, do not that firefox is now disabled until the version fetching mechanism is fixed in travis-multirunner (or djo-shell rather which is a dep of travis multirunner) |
KaptenJansson
added a commit
that referenced
this pull request
Oct 21, 2015
Updating to nodejs 12 and fixing build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like gh-pages is ignored by travis however I found: travis-ci/travis-core#137. Trying it to see if it works.