Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaRecorder demo #696

Merged
merged 4 commits into from Nov 25, 2015
Merged

MediaRecorder demo #696

merged 4 commits into from Nov 25, 2015

Conversation

samdutton
Copy link
Contributor

This is based on Miguel's demo at https://rawgit.com/Miguelao/demos/master/mediarecorder.html.

I've added it to the getUserMedia items on index.html, but we might eventually want to create a section for recording demos.

Works in Firefox, including audio, though for some reason the audio doesn't save properly when you download.

You can try it live at samdutton.github.io/webrtc/src/content/getusermedia/record.

PTAL @miguelao @juberti @KaptenJansson

@fippo
Copy link
Collaborator

fippo commented Nov 23, 2015

  • @jesup @mreavy for the firefox issue, hopefully easy to sort out

@samdutton
Copy link
Contributor Author

Thanks Philipp!

On 23 November 2015 at 08:48, Philipp Hancke notifications@github.com
wrote:


Reply to this email directly or view it on GitHub
#696 (comment).

@@ -0,0 +1,59 @@
<!DOCTYPE html>
<!--
* Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update copyright year.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@KaptenJansson
Copy link
Contributor

Great demo!

Couple of nits otherwise LGTM!

@samdutton
Copy link
Contributor Author

Thanks!

Seems to have stopped working for some reason :). I'll sort out and commit the changes above.

@KaptenJansson
Copy link
Contributor

What has stopped working?

@samdutton
Copy link
Contributor Author

What has stopped working?

With audio: true, playback fails one in every three or four times I record. Video-only recording works every time for me. 49.0.2573.0 canary (64-bit) OS X 10.10.5.

@miguelao — any ideas?

BTW: also not sure why this is happening:

main.js:66 Assertion failed: State should be "recording"

@KaptenJansson
Copy link
Contributor

LGTM, merge if you are all done (not sure with regard to your last comment)

samdutton added a commit that referenced this pull request Nov 25, 2015
@samdutton samdutton merged commit 82b1069 into webrtc:gh-pages Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants