use maplike instead of Object.keys in getStats #851
Conversation
this uses the newer maplike style instead of the older Object.keys()
this uses the newer maplike style instead of the older Object.keys()
this uses the newer maplike style instead of the older Object.keys()
| statsString += '<h3>Report '; | ||
| statsString += index; | ||
| statsString += res.type; |
There was a problem hiding this comment.
Is the type field really the same as the index from the previous iteration?
(just reassure me....)
There was a problem hiding this comment.
hah. I wanted to point out that change. I don't think it makes sense to have a numeric index here. I tried the report id but that got very long and ugly
There was a problem hiding this comment.
@KaptenJansson as samples-maintainer, does this make sense for you?
There was a problem hiding this comment.
I find it a little confusing that we are adding the type to statsString twice. Maybe add a comment to why?
There was a problem hiding this comment.
changed the output format slightly in 486ee45 -- now type, timestamp and id are special
|
@jan-ivar can you please take a look whether this is what we want to show? |
|
Lgtm. |
this uses the maplike syntax instead of the older Object.keys() iteration. Maplike is shimmed by adapter for Chrome.
Code is similar to http://w3c.github.io/webrtc-pc/#example