Add a demo for "Unprocessed volume" #993

alvestrand · 2018-01-16T10:20:03Z

Description
Add a demo that demonstrates the difference between processed and unprocessed audio volume.

This doesn't work right as of Chrome 63 (and probably 65); the PR
is created in order to get the implementation work going.

This doesn't work right as of Chrome 63 (and probably 65); the PR is created in order to get the implementation work going.

KaptenJansson · 2018-02-01T09:54:35Z

src/content/getusermedia/unprocessed-volume/index.html

@@ -0,0 +1,76 @@
+<!DOCTYPE html>
+<!--
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.


Update copyright year.

KaptenJansson · 2018-02-01T09:55:35Z

src/content/getusermedia/unprocessed-volume/js/main.js

@@ -0,0 +1,85 @@
+/*
+ *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.


Update copyright

KaptenJansson · 2018-02-01T09:57:16Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  console.log('First track settings:',
+              JSON.stringify(stream.getAudioTracks()[0].getSettings()));
+  // Set up second track with audio processing disabled
+  constraints.audio = {echoCancellation: {exact: false}};


Why do you have to use exact here?

I think exact is correct if we want two tracks, one with and one without echoCancellation, and demo the difference.

KaptenJansson · 2018-02-01T09:58:12Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  window.stream = stream;
+  var soundMeter = window.soundMeter = new SoundMeter(window.audioContext);
+  soundMeter.connectToSource(stream, function(e) {
+    if (e) {


You could expand e to error since you have space. Also not sure if alert is preferred anymore but not outputting text on the page might not be clear enough.

KaptenJansson · 2018-02-01T09:59:46Z

src/content/getusermedia/unprocessed-volume/js/main.js

+try {
+  window.AudioContext = window.AudioContext || window.webkitAudioContext;
+  window.audioContext = new AudioContext();
+} catch (e) {


You are not printing the actual error, e is unused.

I believe you can do try { } catch { }.

KaptenJansson · 2018-02-01T10:00:12Z

src/content/getusermedia/unprocessed-volume/js/main.js

+          soundMeter.slow.toFixed(2);
+    }, 200);
+  });
+  console.log('First track settings:',


Use trace instead?

KaptenJansson · 2018-02-01T10:01:12Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  });
+}
+
+function handleError(error) {


You could make a generic error handler here and pass it to connectToSource error callbacks as well.

KaptenJansson · 2018-03-08T11:58:56Z

Any cycles to finish this?

KaptenJansson · 2018-03-26T11:49:15Z

Ping

fippo · 2018-03-28T19:20:59Z

src/content/getusermedia/unprocessed-volume/index.html

+    <p>Note that you will not hear your own voice; use the <a href="../audio">local audio rendering demo</a> for that.</p>
+    <p>The <code>audioContext</code>, <code>stream</code> and <code>soundMeter</code> variables are in global scope, so you can inspect them from the console.</p>
+
+    <a href="https://github.com/webrtc/samples/tree/gh-pages/src/content/getusermedia/volume" title="View source for this page on GitHub" id="viewSource">View source on GitHub</a>


- Fixed error handling

googlebot · 2018-06-14T13:35:55Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ErikHellman · 2018-06-14T13:41:09Z

Fixed all the outstanding issues and converted all vars to const/let.

Seems like the CLA check doesn't like my other email. I'll fix this for future PRs, but they

henbos · 2018-06-15T15:14:54Z

src/content/getusermedia/unprocessed-volume/js/main.js

+try {
+  window.AudioContext = window.AudioContext || window.webkitAudioContext;
+  window.audioContext = new AudioContext();
+} catch (e) {


I believe you can do try { } catch { }.

henbos · 2018-06-15T15:16:50Z

src/content/getusermedia/unprocessed-volume/js/main.js

+          soundMeter.slow.toFixed(2);
+    }, 200);
+  });
+  console.log('First track settings:',


henbos · 2018-06-15T15:18:46Z

src/content/getusermedia/unprocessed-volume/js/main.js

+
+// Put variables in global scope to make them available to the browser console.
+let constraints = window.constraints = {
+  audio: {echoCancellation: true},


Should this be echoCancellation: {exact:true} so that we fail if it cannot be satisfied?

I find it confusing and error prone that the same constraints are setup up as a global variable, then used, then modified. If the demo were to have a reset button it would stop working unless this is explicitly reset. I've also not seen "let constraints = window.constraints = ...". Wouldn't "let constraints" work? Or if that didn't work, why not "var constraints"? I don't see this variable adding anything.

Can we just pass the desired constraints when we call getUserMedia? Not have a variable for it.

Ping @alvestrand. I didn't update this part. :)

henbos · 2018-06-15T15:19:24Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  console.log('First track settings:',
+              JSON.stringify(stream.getAudioTracks()[0].getSettings()));
+  // Set up second track with audio processing disabled
+  constraints.audio = {echoCancellation: {exact: false}};


I think exact is correct if we want two tracks, one with and one without echoCancellation, and demo the difference.

henbos · 2018-06-15T15:23:21Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  alert('Web Audio API not supported.');
+}
+
+// Put variables in global scope to make them available to the browser console.


I'm not sure what what this means.

sam wrote this... but var at top scope have always been available in the console or window[]. No longer true for es6 const/let notably.

henbos · 2018-06-15T15:26:33Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  video: false
+}
+
+function handleSuccess(stream) {


Can we do async/await instead? Promise-chains with callbacks are harder to follow.

While I agree that it is easier to read, I'm not sure it's suitable for these samples. My guess is that most JavaScript developers are more familiar with promises than async/await.

that is the reason there was no push for es6... stackoverflow is still full of people who use the callback API but we had to move the needle there

I've changed my mind on this. async/await is better in most cases than promise-chains. We should be good citizens and push the use of that. :)

henbos · 2018-06-15T15:30:49Z

Did I review the latest changes or did googlebot block you? I saw comments from February on the files I commented on

ErikHellman · 2018-07-26T20:15:30Z

@alvestrand I need your approval on this so that the Google CLA gets happy again. :)

- Added missing semicolons - Converted callbacks to prmoises (async/await)

fippo · 2018-08-21T13:56:06Z

src/content/getusermedia/unprocessed-volume/js/main.js

+  console.log('First track settings:', audioSettings);
+
+  // Set up second track with audio processing disabled
+  constraints.audio = {echoCancellation: {exact: false}};


any reason why this is {exact: false} and not false?

He's away at the moment

ErikHellman · 2018-08-29T10:52:41Z

Closing this for now as we're not ready to publish this yet.

Add a demo for "Unprocessed volume"

35da7a0

This doesn't work right as of Chrome 63 (and probably 65); the PR is created in order to get the implementation work going.

googlebot added the cla: yes label Jan 16, 2018

Linted

511e8f8

alvestrand mentioned this pull request Jan 17, 2018

Add stat for inputAudioLevel, before the audio filter w3c/webrtc-stats#271

Closed

KaptenJansson previously requested changes Feb 1, 2018

View reviewed changes

fippo reviewed Mar 28, 2018

View reviewed changes

Erik Hellman added 2 commits June 14, 2018 14:27

Corrected the copyright year.

3270564

- Use const/let instead of var

b08d2f9

- Fixed error handling

googlebot added cla: no and removed cla: yes labels Jun 14, 2018

Merge branch 'gh-pages' into unprocessed-volume

a8008a4

ErikHellman requested a review from henbos June 14, 2018 13:40

henbos requested changes Jun 15, 2018

View reviewed changes

ErikHellman added 4 commits July 4, 2018 13:57

Merge branch 'gh-pages' into unprocessed-volume

ed5f742

Merge branch 'gh-pages' into unprocessed-volume

927b73c

Merge branch 'gh-pages' into unprocessed-volume

23e74df

Merge branch 'gh-pages' into unprocessed-volume

31d636a

Fixed lint errors and async/await refactoring

1e7da70

- Added missing semicolons - Converted callbacks to prmoises (async/await)

fippo reviewed Aug 21, 2018

View reviewed changes

ErikHellman closed this Aug 29, 2018

alvestrand deleted the unprocessed-volume branch April 3, 2020 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a demo for "Unprocessed volume" #993

Add a demo for "Unprocessed volume" #993

alvestrand commented Jan 16, 2018

KaptenJansson Feb 1, 2018

KaptenJansson Feb 1, 2018

KaptenJansson Feb 1, 2018

henbos Jun 15, 2018

KaptenJansson Feb 1, 2018

KaptenJansson Feb 1, 2018

henbos Jun 15, 2018

KaptenJansson Feb 1, 2018

henbos Jun 15, 2018

KaptenJansson Feb 1, 2018

KaptenJansson commented Mar 8, 2018

KaptenJansson commented Mar 26, 2018

fippo Mar 28, 2018

googlebot commented Jun 14, 2018

ErikHellman commented Jun 14, 2018

henbos Jun 15, 2018

henbos Jun 15, 2018

henbos Jun 15, 2018

henbos Jun 15, 2018

ErikHellman Jun 16, 2018

henbos Jun 15, 2018

henbos Jun 15, 2018

fippo Jul 27, 2018

henbos Jun 15, 2018

ErikHellman Jun 16, 2018

fippo Jun 16, 2018

ErikHellman Jul 23, 2018

henbos commented Jun 15, 2018

ErikHellman commented Jul 26, 2018

fippo Aug 21, 2018

ErikHellman commented Aug 29, 2018

		@@ -0,0 +1,85 @@
		/*
		* Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.

Add a demo for "Unprocessed volume" #993

Add a demo for "Unprocessed volume" #993

Conversation

alvestrand commented Jan 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KaptenJansson commented Mar 8, 2018

KaptenJansson commented Mar 26, 2018

Choose a reason for hiding this comment

googlebot commented Jun 14, 2018

ErikHellman commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

henbos commented Jun 15, 2018

ErikHellman commented Jul 26, 2018

Choose a reason for hiding this comment

ErikHellman commented Aug 29, 2018