Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Mic test - Clipping should be a warning, not failure #84

Closed
KaptenJansson opened this issue May 14, 2015 · 3 comments
Closed

Mic test - Clipping should be a warning, not failure #84

KaptenJansson opened this issue May 14, 2015 · 3 comments
Assignees

Comments

@KaptenJansson
Copy link
Contributor

I think we should change the fail criteria for clipping in the mic test due to lots of Mic's on Chromebooks, 3.5mm headsets and some Windows laptops have high input volume due to I guess to make sure it can get sufficiently high enough input when the user is far away from the mic. Or the quality/config is just bad in general on these devices.

I propose changing from error to info.

fsolenberg@ WDYT?

@fsolenberg
Copy link
Contributor

SGTM. Sorry for the late reply.

@fsolenberg
Copy link
Contributor

Actually, figured it is better to mark these events with a WARNing instead of INFO. Maybe the test should go yellow too? #85

@KaptenJansson
Copy link
Contributor Author

I agree on yellow warnings.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants