Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Make clip detect a warning message instead of error. #85

Merged
merged 5 commits into from
May 28, 2015

Conversation

fsolenberg
Copy link
Contributor

Bump webcomponents rev to 0.6.1 to stop bower from complaining.

…ts rev to 0.6.1 to stop bower from complaining.
@KaptenJansson
Copy link
Contributor

I think we need install a specific version of vulcanize, try "sudo npm install -g vulcanize@0.7.10" locally and if it works then add it to https://github.com/webrtc/testrtc/blob/master/.travis.yml and see if travis can build successfully.

@fsolenberg
Copy link
Contributor Author

Yeah, I used @0.7.0 locally and it worked. I can update travis.yml. But first, tell me what's the point of vulcanize, except making the change/test cycle more complicated? It didn't look like the resulting file contained minimized js (or html/css), so IIUC it is mostly about making the load time slightly shorter by making only one request to load the whole app? Is this saving really worth the extra trouble?

@KaptenJansson
Copy link
Contributor

I thought I answered this but we have seen significant improvement by using vulcanize on slower connections. I do agree however there is extra work involved using vulcanize.....

When there is some time I plan on making this process better with build scripts and auto deploy etc.

@KaptenJansson
Copy link
Contributor

You do not have to worry now, I've submitted a pull request #87 for an issue where I also fix this. So you just need to rebase.

@fsolenberg
Copy link
Contributor Author

Think this is ready for merge now.

@KaptenJansson
Copy link
Contributor

LGTM however there is a dependency issue in ToT right now which will cause polymer elements to fail rendering, see issue #89. I will try to fix it today. Will however merge this.

KaptenJansson added a commit that referenced this pull request May 28, 2015
Make clip detect a warning message instead of error.
@KaptenJansson KaptenJansson merged commit b15dbae into master May 28, 2015
@KaptenJansson KaptenJansson deleted the error_to_info branch May 28, 2015 08:48
@KaptenJansson
Copy link
Contributor

So what that means is that I won't be able to push the latest ToT to GAE until I've fixed #89.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants