safari: fix createOffer callbacks API #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug where the legacy callbacks API for Safari createOffer didn't return as expected when compared to the currently working promises API. This was due to the order of shims in adapter_factory, where the shimCreateOfferLegacy which does trasceiver stuff and overwrites the createOffer prototype was called after shimCallbacksAPI already fixed the createOffer function to support callbacks. Moreover, this happened only because the order of arguments to createOffer int he first place, where the callbacks come first (wtf) before the options, meaning that the options argument changes order between the callback and promise API. If only we could go back in time... Fixes webrtcHacks#859
|
test failure is due to #857, i'll fix that tomorrow |
|
the rationale for the old order was that you always want a callback (because you need the sdp) but only sometimes need to specify options. |
fippo
approved these changes
Aug 2, 2018
|
will do a new release tomorrow after fixing #857. Also for tradition sake: 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where the legacy callbacks API for Safari
createOffer didn't return as expected when compared to the currently
working promises API.
This was due to the order of shims in adapter_factory, where the
shimCreateOfferLegacy which does trasceiver stuff and overwrites the
createOffer prototype was called after shimCallbacksAPI already fixed
the createOffer function to support callbacks.
Moreover, this happened only because the order of arguments to
createOffer int he first place, where the callbacks come first (wtf)
before the options, meaning that the options argument changes order
between the callback and promise API. If only we could go back in
time...
Fixes #859
Description
Purpose