Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 9 "split" issue unaccounted for #15

Closed
jrhooker opened this issue Mar 4, 2013 · 6 comments
Closed

IE 9 "split" issue unaccounted for #15

jrhooker opened this issue Mar 4, 2013 · 6 comments

Comments

@jrhooker
Copy link

jrhooker commented Mar 4, 2013

Hello,

Very nice script, but doesn't work in IE 9 due to its dependence on the "split" function.

Cheers,
Jeff.

@websanova
Copy link
Owner

Thanks, will take a look soon.
On Mar 4, 2013 6:46 PM, "jrhooker" notifications@github.com wrote:

Hello,

Very nice script, but doesn't work in IE 9 due to its dependence on the
"split" function.

Cheers,
Jeff.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15
.

@websanova
Copy link
Owner

Wait a second, IE supports split function, what are you running that is giving you the error? It could be a specific string that's breaking it.

@jrhooker
Copy link
Author

jrhooker commented Mar 5, 2013

IE does "support" it, but in IE9 it's broken.

On Tue, Mar 5, 2013 at 4:56 AM, Nova notifications@github.com wrote:

Wait a second, IE supports split function, what are you running that is
giving you the error? It could be a specific string that's breaking it.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-14438467
.

@websanova
Copy link
Owner

Just ran this in ie9: http://jsfiddle.net/Xnvrf/

Seems to work fine.

Do you have any specific info you can attach, links, examples, device
you're using, anything might be useful to pinpoint the problem.

On Tue, Mar 5, 2013 at 12:07 PM, jrhooker notifications@github.com wrote:

IE does "support" it, but in IE9 it's broken.

On Tue, Mar 5, 2013 at 4:56 AM, Nova notifications@github.com wrote:

Wait a second, IE supports split function, what are you running that is
giving you the error? It could be a specific string that's breaking it.


Reply to this email directly or view it on GitHub<
https://github.com/websanova/js-url/issues/15#issuecomment-14438467>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-14451773
.

@evoactivity
Copy link

I've never had a problem with ie9 and split, do you have any examples
jrhooker?

On 05/03/2013 17:26, Nova wrote:

Just ran this in ie9: http://jsfiddle.net/Xnvrf/

Seems to work fine.

Do you have any specific info you can attach, links, examples, device
you're using, anything might be useful to pinpoint the problem.

On Tue, Mar 5, 2013 at 12:07 PM, jrhooker notifications@github.com
wrote:

IE does "support" it, but in IE9 it's broken.

On Tue, Mar 5, 2013 at 4:56 AM, Nova notifications@github.com wrote:

Wait a second, IE supports split function, what are you running
that is
giving you the error? It could be a specific string that's
breaking it.


Reply to this email directly or view it on GitHub<
https://github.com/websanova/js-url/issues/15#issuecomment-14438467>
.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/15#issuecomment-14451773
.


Reply to this email directly or view it on GitHub
#15 (comment).

@jrhooker
Copy link
Author

jrhooker commented Mar 6, 2013

Profoundly odd.

The function that brought this to my attention was:

function doOnRowSelected(rowId) {
var rowIdArray = rowId.split( "|" );
if (rowIdArray[1] == null){
window.location.assign(rowIdArray[0] +
'.html' + '?origin=' + escape(window.document.title));
} else {
window.location.assign(rowIdArray[0] +
'.html?row=' + rowIdArray[1] + '&origin=' + escape(window.document.title));
}
}

It worked in every browser but IE9, so I did some digging and found a bunch
of threads saying that "split" was broken in IE9.

So I found a function to replace it, but once that was fixed, URL
processing was broken too, so I looked into your JS files and found a great
whack of "split" function use, thought "AhHa!", replaced your URL parser
with another, and now everything works.

An now, of course, I can't make "split" break in IE9 any more.

My apologies; it was likely just a mistake on my part. If I have time to
restore my code from source and track the problem down a second time I'll
update you with the outcome, but at this point I've got to keep moving
forward.

Cheers,
Jeff.

On Tue, Mar 5, 2013 at 9:27 AM, Liam Potter notifications@github.comwrote:

I've never had a problem with ie9 and split, do you have any examples
jrhooker?

On 05/03/2013 17:26, Nova wrote:

Just ran this in ie9: http://jsfiddle.net/Xnvrf/

Seems to work fine.

Do you have any specific info you can attach, links, examples, device
you're using, anything might be useful to pinpoint the problem.

On Tue, Mar 5, 2013 at 12:07 PM, jrhooker notifications@github.com
wrote:

IE does "support" it, but in IE9 it's broken.

On Tue, Mar 5, 2013 at 4:56 AM, Nova notifications@github.com wrote:

Wait a second, IE supports split function, what are you running
that is
giving you the error? It could be a specific string that's
breaking it.


Reply to this email directly or view it on GitHub<
https://github.com/websanova/js-url/issues/15#issuecomment-14438467>
.


Reply to this email directly or view it on
GitHub<
https://github.com/websanova/js-url/issues/15#issuecomment-14451773>
.


Reply to this email directly or view it on GitHub
#15 (comment).


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-14452944
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants