-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE Browser Comapatiblity #2
Comments
Did you test if the issue was from the original plugin or is it specific for the plus new features, |
The function you have override "measureColumns" creates the issue in IE as On Oct 24, 2016 1:39 AM, "Adnan M.Sagar, PhD" notifications@github.com
|
I finally found the solution! |
I've looked at the issue fix, the code of 'measureColumns' isn't different from the current masonry-plus 1.0.1 code!! |
check lines 67-76 in "masonry-plus 1.0.1 " and compare with the issue.. there are small changes. |
1- masonry-plus 1.0.1 (67-76) // if columnWidth is 0, default to outerWidth of first item
if ( !this.columnWidth ) {
/* var firstItem = this.items[0] old code */
var firstItem = this.items.find(function(item) {return !item.isIgnored})
var firstItemElem = firstItem && firstItem.element
// columnWidth fall back to item of first element
this.columnWidth = firstItemElem && getSize( firstItemElem ).outerWidth ||
// if first elem has no width, default to size of container
this.containerWidth
} 2- masonry.js (64-69) // if columnWidth is 0, default to outerWidth of first item
if ( !this.columnWidth ) {
var firstItem = this.items[0];
var firstItemElem = firstItem && firstItem.element;
// columnWidth fall back to item of first element
this.columnWidth = firstItemElem && getSize( firstItemElem ).outerWidth ||
// if first elem has no width, default to size of container
this.containerWidth;
} 3- Changes, This, var firstItem = this.items[0] Changed to, var firstItem = this.items.find(function(item) {return !item.isIgnored}) As per issue #1, Or am I missing something more obvious here? |
You can changed above, in the jsfiddle issue #1 while running it with Internet Explorer, then compare with masonry-plus 1.0.1. |
Hi again, Hope you are doing well
I found another issue.
The plugin does not work properly with IE. I tried Internet Explorer 11, and when I load the page which I have created, the plugin doesn't work and masonry layout is not proper, and it effects other contents as well..
Would You Please make it cross-browser
Thank You in advance again :-)
Have a Good day!
The text was updated successfully, but these errors were encountered: