-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards compatibility for Quick Cache __advanced_cache is missing #710
Comments
@jaswsinc Ping. ↑ |
I just reviewed the codebase again. Yes, that should to it. I had doubts that it would, because themes like Weaver II that integrated with this were also dependent upon old Quick Cache hook names (or so I thought), but as it turns out the hook name we suggested was prefixed with |
Just to confirm, we are not supporting Quick Cache backward compat in Comet Cache, right? This particular issue can be resolved easily, which is what I think you're trying to do since it is simple. However, moving forward we aren't trying to support the old Quick Cache hook names/filters/constants/globals etc. Do I have that right? |
Yes, that's correct. |
Next Release Changelog:
|
Comet Cache v160416 has been released and includes changes from this GitHub Issue. See the v160416 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#710). |
Originally reported here: https://wordpress.org/support/topic/backwards-compatibility-with-oldquickcache-advanced-cache-plugins-is-broken?replies=1
It appears that we missed backwards compatibility for
quick_cache__advanced_cache
in theadvanced-cache.txt
template: https://github.com/websharks/comet-cache/blob/160227/src/includes/templates/advanced-cache.txt#L221-L226All we should need is the following added to that file:
Do you concur @jaswsinc?
The text was updated successfully, but these errors were encountered: