Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pro Options Panel header when logo is hidden #76

Closed
wants to merge 4 commits into from

Conversation

renzms
Copy link
Contributor

@renzms renzms commented Jun 24, 2016

@renzms
Copy link
Contributor Author

renzms commented Jun 24, 2016

@raamdev

  • Removed the Restore button
  • Made it a link
  • Tested, link prompts the dialog box asking if user is sure they want to restore settings

With Logo

screen shot 2016-06-24 at 8 02 07 am

Problem


Without Logo

Header has extra white space and margin for positioning the gray division bar.
screen shot 2016-06-24 at 8 10 02 am

Editing the padding and margins moves around the division bar between heading and content.

Adjusted the CSS to make it so that the body's positioning would determine the position of the bar, since the header is variable (logo optional, different pro/lite header links, etc). Since the body would always have a fixed position, made it's new position before the body.

For some reason though, the division bar ends at the bottom of the panel, although the CSS is using ::before

screen shot 2016-06-24 at 9 05 48 am

@jaswrks
Copy link

jaswrks commented Jun 29, 2016

@renzms I updated this PR with some tweaks to assist you. Please review and if you find it acceptable please notify Raam so he can do a review and merge.

Screenshots

2016-06-29_01-24-30


2016-06-29_01-24-52


2016-06-29_01-25-17


2016-06-29_01-25-35

@jaswrks
Copy link

jaswrks commented Jun 29, 2016

@renzms writes...

division bar ends at the bottom of the panel, although the CSS is using ::before

The ::before pseudo selector decides where the content element will be inserted into the DOM. It doesn't decide how it is positioned inside the element it's inserted into. In this case, the element is inserted into the DOM ::before all other elements, and then positioning absolutely to the bottom: 0.

2016-06-29_00-43-24

@renzms
Copy link
Contributor Author

renzms commented Jun 29, 2016

@jaswsinc Thanks for the assist! It all looks better to me! So instead of a division bar, it will have the "note" to divide the header and the content?

@raamdev What do you think?

@jaswrks
Copy link

jaswrks commented Jun 29, 2016

@renzms writes...

have the "note" to divide the header and the content?

The notice is there, but it's not responsible for being the divider, because it may or may not apply; i.e., it may not be shown in all cases, so we can't rely upon that element. That notice just needs to fit properly whenever it is present is all.

What I did is I set a new ::after pseudo selector to force a clearing of the heading. Then I removed the padding and adjusted the margin on the notice when it's present. See: 96ad8fb#diff-6d5698e58e9090f25b226ff8f1ce1769R682

@renzms
Copy link
Contributor Author

renzms commented Jul 12, 2016

Added in work from #75 :

Add social links to plugin options page

LITE

screen shot 2016-06-29 at 12 10 43 am

PRO

screen shot 2016-06-29 at 12 10 04 am

@renzms
Copy link
Contributor Author

renzms commented Jul 25, 2016

@raamdev

Hi Raam, between the work from #75 : (Add social links to plugin options page) and @jaswsinc 's updated responsive tweaks above, is there anything else we can improve upon for this featured branch?

@raamdev
Copy link
Contributor

raamdev commented Jul 29, 2016

@renzms This looks great! I just ran it through a few tests. Beautiful! I love how the whole thing adapts to the browser even when it's mobile-size.

2016-07-29_17-20-02

@raamdev
Copy link
Contributor

raamdev commented Jul 29, 2016

There was a small issue with the spacing between links:

2016-07-29_17-43-37

Fixed in 85428a3:

2016-07-29_17-43-24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants