Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify config sub-section menu items; See: websharks/comment-mail#187 #212

Closed
wants to merge 5 commits into from

Conversation

kristineds
Copy link
Contributor

Simplify config sub-section menu items;

  • Rename "Restore Default Options" to "Restore", move designated icon to end of the text, and convert text link to blue button (green on hover)
  • Add "Beta Testers" text link with icon
  • Move "Restore" button, "Newsletter","Beta Testers", "Pro Upgrade", "Preview Pro Features" text link to upper right side of plugin options panel

Simplify sub section menu items - v1.0 (Lite)

See: #187

@kristineds
Copy link
Contributor Author

NOTE: This is a work-in-progress. Still working on the following:

  • Display installed version number on plugin options panel

@kristineds
Copy link
Contributor Author

@raamdev @jaswsinc This is ready for review

  • Show installed version number (with link to changelog): 3bf3535

screen shot 2016-01-27 at 12 47 40 am

@raamdev
Copy link
Contributor

raamdev commented Jan 26, 2016

@kristineds That looks awesome! Can we get a PR for the Pro version as well? :-)

$heading .= ' </div>'."\n";

$heading .= ' <div class="pmp-version">'."\n";
$heading .= ' <span> '.sprintf(__('%1$s&trade; Pro v%2$s (<a href="https://comment-mail.com/changelog/">changelog</a>)', 'comment-mail'), esc_html($this->plugin->name), esc_html($this->plugin->version)).'</span>'."\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristineds This shouldn't say "Pro" for the Lite version...

@kristineds
Copy link
Contributor Author

@raamdev "Pro" text removed on version number. 4ffbc2f

screen shot 2016-01-27 at 1 36 00 am

@raamdev
Copy link
Contributor

raamdev commented Feb 1, 2016

Changing this to in progress until there's some more clarity around the status of this PR and its Pro counterpart; see wpsharks/comment-mail-pro#46 (comment).

@kristineds
Copy link
Contributor Author

@raamdev I posted my PR for the Pro version here.

@raamdev
Copy link
Contributor

raamdev commented Feb 6, 2016

@kristineds Thank you! I reviewed this and the Pro PR; here's some feedback:

The group of links with text-align: center; doesn't look right; there's too much space to the right of the links:

2016-02-05_21-13-10

I'd like all of those links and the Restore button to line up with on the right side. I also suggest increasing the line-height to 1.75em for the links to separate them out a bit. This is how it should look when finished:

2016-02-05_21-17-08


I'm making a similar request for the Pro version; I'll post screenshots on that PR.

@kristineds
Copy link
Contributor Author

@raamdev Submitting PR for Lite version: bf3c649 & 4ac4b5a
(Forgot about the Restore button so I have to push another commit for this)

screen shot 2016-02-07 at 12 36 41 am

@raamdev
Copy link
Contributor

raamdev commented Feb 8, 2016

@kristineds I tested this PR and the alignment looks great now! Thank you.

@raamdev raamdev closed this Feb 8, 2016
@raamdev raamdev deleted the feature/187 branch February 8, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants