Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I add the New EOT Shortcode to the PRO Login Widget? #253

Closed
5 of 6 tasks
renzms opened this issue Aug 12, 2015 · 6 comments
Closed
5 of 6 tasks

Can I add the New EOT Shortcode to the PRO Login Widget? #253

renzms opened this issue Aug 12, 2015 · 6 comments

Comments

@renzms
Copy link
Contributor

renzms commented Aug 12, 2015

KB Article Creation Checklist
  • Write initial draft for this KB Article; label this issue draft and either questions or tutorials
  • Add required YAML configuration
  • Add Tags for this KB Article to the YAML config (see YAML Keys (Explained))
  • Edit and finalize draft for publishing (remove draft label, add draft-finalized label)
  • Assign Issue to yourself and create Markdown file (remove draft-finalized label, add pending)
  • Project Lead: Review and Publish KB Article (remove pending label, add published label)

Published @ s2Member.com: http://s2member.com/kb-article/can-the-eot-time-be-added-to-the-pro-login-widget/

View Markdown File

@jaswrks
Copy link
Contributor

jaswrks commented Aug 12, 2015

Hey! :-) Great to see you working on KBAs like this. Thank you!


Can I Add The New EOT Shortcode To PRO Login Widget?

Questions can be written without title-case.
e.g., Can I add the new EOT Shortcode to the Pro Login Widget?

Note that:

  • I am using regular sentence-case; e.g., Can I add the new...
  • However, I always capitalize feature titles like: Pro Login Widget and EOT Shortcode

Yes, you should be able to add it using PHP code

I realize this is just a draft, but try to refrain from using words like "should" or "might" or "maybe". You want the article to present an official answer to the question. Words like should or maybe suggest that it might be the right answer, and that's not what people want to see in the official KB for the software.

Remember you can always ask one of us if you're unsure.


The Pro Login Widget supports arbitrary XHTML/PHP and even shortcodes. So I don't think it's absolutely necessary to install something like ezPHP to answer this question. I think mentioning ezPHP is great, but we should also mention that the Pro Login Widget has these fields that you can use. In fact, you could even insert the [s2Eot /] shortcode right into these fields.

2015-08-12_01-17-04

@raamdev
Copy link
Contributor

raamdev commented Aug 12, 2015

In fact, you could even insert the [s2Eot /] shortcode right into these fields.

@jaswsinc Interesting. I was not even aware of that. :-) Should any WordPress shortcode work there? If so, maybe we can change those field titles to "Additional XHTML/PHP Code or Shortcode?"

@renzms
Copy link
Contributor Author

renzms commented Aug 13, 2015

@jaswsinc

Thanks for the feedback and guidance! I'll take note of the changes and edit the draft. I didn't know you could just use the short code straight into the widget fields, so thanks for that too. I'll make the article explain that shortcode can be used to show EOT and also the method for using PHP as an additional method to show EOT. That should cover all bases.

@renzms renzms changed the title Can I Add The New EOT Shortcode To PRO Login Widget? Can I add the New EOT Shortcode to the PRO Login Widget? Aug 13, 2015
@renzms renzms self-assigned this Aug 19, 2015
@renzms
Copy link
Contributor Author

renzms commented Aug 19, 2015

"Additional XHTML/PHP Code or Shortcode?"

@jaswsinc and @raamdev , I agree with Raam, maybe it should include the words "and Shortcodes". But like he asked, are there any limitations on the shortcodes that should work, or is it only applicable to certain s2member shortcodes?

@jaswrks
Copy link
Contributor

jaswrks commented Aug 21, 2015

Should any WordPress shortcode work there?

Yes. Any shortcode should work here. I'm opening an issue here. I agree.
wpsharks/s2member#691

@jaswrks
Copy link
Contributor

jaswrks commented Aug 21, 2015

@renzms Latest improvements look good! :-)

raamdev added a commit that referenced this issue Aug 24, 2015
raamdev added a commit that referenced this issue Aug 25, 2015
@raamdev raamdev added published and removed pending labels Aug 25, 2015
@raamdev raamdev closed this as completed Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants