Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWeber IPv6 Addresses #611

Closed
jaswrks opened this issue Jul 2, 2015 · 4 comments
Closed

AWeber IPv6 Addresses #611

jaswrks opened this issue Jul 2, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Jul 2, 2015

Referencing: https://websharks.zendesk.com/agent/tickets/7066

can you PLEASE consider adding the option to turn off the IP address now that we heard from Aweber that it's not mandatory? Or a PHP code check that will not send the IP address to Aweber unless it's in a valid IPv4 format now that we know that Aweber does not accept IPv6 format? Pretty please with sugar on top.

Description

AWeber chokes on IPv6 addresses; i.e., if a subscriber has an IPv6 address, they cannot subscribe. A possible solution would be for s2Member to try to detect this and simply send an empty string in this case. We have confirmation that IP addresses are not required by AWeber.

If not the default behavior, an easy hook/filter would be nice.

@jaswrks jaswrks added the bug label Jul 2, 2015
jaswrks pushed a commit that referenced this issue Jul 12, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 12, 2015

Next Release Changelog:

  • (s2Member/s2Member Pro) AWeber Compat. This release resolves an issue with AWeber rejecting subscribers that have IPv6 addresses. Until such time as AWeber adds support for IPv6 addresses, s2Member will simply send an empty IP address whenever it encounters an IPv6 address. This behavior was requested by the AWeber team. See this GitHub issue if you'd like additional details.

@jaswrks jaswrks closed this as completed Jul 12, 2015
@jaswrks jaswrks added this to the Next Release milestone Jul 12, 2015
@jaswrks jaswrks self-assigned this Jul 12, 2015
@JoeCotellese
Copy link

@jaswsinc - glad it got fixed. You took care of it before I had a chance to comment :) Let me know if you're still seeing issue.

Regards,

Joe C
Director of Product
AWeber Communications

@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 14, 2015

👍 Thanks Joe! :-)

@jaswrks
Copy link
Contributor Author

jaswrks commented Jul 23, 2015

The latest release of s2Member v150722+ closes this issue.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one. Thanks! :-)

@wpsharks wpsharks locked and limited conversation to collaborators Jul 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants