New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe subscription popover should auto-fill with checkout details #749
Comments
Next Release Changelog:
|
@jaswsinc writes...
I think you have that backwards... this GitHub issue was opened to address Subscription (i.e., a recurring subscription) Pro-Forms not filling in the Stripe popup... Buy Now / Fixed-Term Pro-Forms were already working fine. |
I see what you mean. I'll leave this open then. The work that I've done here (thus far) was to bring the Buy Now description and amount into the Stripe popup in all cases. In the existing release of s2Member Pro, this only occurs whenever you have Bitcoin enabled. With the work that was done here, it now occurs for all Buy Now purchases, even if Bitcoin is not enabled. |
I'm going to punt the remaining work on this for now. There are too many variables in play when it comes to recurring vs. non-recurring; plus taxes, coupons, percentage-based gifts, etc. At the moment, all of that is handled server-side and it will be difficult to pipe all of those calculations through to the JS routines that power Stripe before checkout has been initiated. So it will take more time for us to get the Subscription calculations into JS routines. I did manage to get these details in there for all Buy Now transactions though, so that should be a significant improvement for many sites in the upcoming release. |
Any progress on this one? |
The modal was removed in the updated Stripe integration. #1168 |
When a Stripe Pro-Form is used for a Subscription (as opposed to a Buy Now transaction), the Stripe popover does not fill in with the checkout details as it does with the Buy Now transactions.
The following is missing for s2Member Stripe subscription checkout methods:
Here's what an s2Member Stripe Pro-Form for subscriptions looks like:
The missing data is confusing to s2Member users (and their customers) because the Stripe form looks incomplete or like it's missing data.
Related (but recently closed) issues:
locale
Attribute #728The text was updated successfully, but these errors were encountered: