Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe subscription popover should auto-fill with checkout details #749

Closed
raamdev opened this issue Oct 10, 2015 · 6 comments
Closed

Stripe subscription popover should auto-fill with checkout details #749

raamdev opened this issue Oct 10, 2015 · 6 comments

Comments

@raamdev
Copy link
Contributor

raamdev commented Oct 10, 2015

When a Stripe Pro-Form is used for a Subscription (as opposed to a Buy Now transaction), the Stripe popover does not fill in with the checkout details as it does with the Buy Now transactions.

The following is missing for s2Member Stripe subscription checkout methods:

2015-10-10_13-38-31

Here's what an s2Member Stripe Pro-Form for subscriptions looks like:

2015-10-10_13-42-20

The missing data is confusing to s2Member users (and their customers) because the Stripe form looks incomplete or like it's missing data.


Related (but recently closed) issues:

@raamdev raamdev added this to the Next Release milestone Oct 10, 2015
jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue Oct 30, 2015
@jaswrks jaswrks self-assigned this Oct 30, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Oct 30, 2015

Next Release Changelog:

  • (s2Member Pro) Stripe Enhancement: This release updates s2Member's Stripe integration so that any Buy Now transaction spawns a Stripe popup with the amount and full description filled within the popup itself as well. Props @raamdev. See this GitHub issue for further details.

@jaswrks jaswrks closed this as completed Oct 30, 2015
@raamdev
Copy link
Contributor Author

raamdev commented Oct 30, 2015

@jaswsinc writes...

Buy Now transaction spawns a Stripe popup

I think you have that backwards... this GitHub issue was opened to address Subscription (i.e., a recurring subscription) Pro-Forms not filling in the Stripe popup... Buy Now / Fixed-Term Pro-Forms were already working fine.

@raamdev raamdev reopened this Oct 30, 2015
@jaswrks
Copy link
Contributor

jaswrks commented Oct 30, 2015

I see what you mean. I'll leave this open then.

The work that I've done here (thus far) was to bring the Buy Now description and amount into the Stripe popup in all cases. In the existing release of s2Member Pro, this only occurs whenever you have Bitcoin enabled. With the work that was done here, it now occurs for all Buy Now purchases, even if Bitcoin is not enabled.

@jaswrks
Copy link
Contributor

jaswrks commented Dec 4, 2015

Subscription (i.e., a recurring subscription) Pro-Forms not filling in the Stripe popup

I'm going to punt the remaining work on this for now. There are too many variables in play when it comes to recurring vs. non-recurring; plus taxes, coupons, percentage-based gifts, etc. At the moment, all of that is handled server-side and it will be difficult to pipe all of those calculations through to the JS routines that power Stripe before checkout has been initiated.

So it will take more time for us to get the Subscription calculations into JS routines. I did manage to get these details in there for all Buy Now transactions though, so that should be a significant improvement for many sites in the upcoming release.

@raamdev raamdev modified the milestones: Next Release, Future Release Dec 9, 2015
@jaswrks jaswrks modified the milestones: Next Release, Future Release Dec 18, 2015
@jaswrks jaswrks modified the milestones: Future Release, Next Release Apr 23, 2016
@raamdev raamdev modified the milestones: Next Release, Future Release Oct 12, 2016
@raamdev raamdev modified the milestones: Future Future Release, Future Release Nov 21, 2016
@Woohoo61
Copy link

Woohoo61 commented Sep 5, 2017

Any progress on this one?
The Stripe popup is still the same (meaning: no aditional info is shown) as of october 2015.

@clavaque
Copy link
Contributor

The modal was removed in the updated Stripe integration. #1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants