New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: JW Player v7 Compatibility Issue #774

Closed
renzms opened this Issue Nov 3, 2015 · 21 comments

Comments

Projects
None yet
8 participants
@renzms
Contributor

renzms commented Nov 3, 2015

Overview

We want to make JW Player v7 compatible with s2member. There is an error message after trying to upload files and use JW Player v7 with s2member. JW Player v7 is not yet compatible with s2Member as all of the code samples and [s2Stream/] shortcode are intended for JW Player v6.

Steps to Reproduce

  • Upgrade to/install JW Player v7 + s2member
  • Upload media files
  • Attempt to play media

Expected Behavior

Files will play normally via JW Player.

Observed Behavior

Error message prompt.

When uploading files to website, message prompts: "Error setting up player: Missing license key".

Temporary Fix

Please revert JW Player to v6 to correct this error.


referenced in internal ticket: https://websharks.zendesk.com/agent/tickets/9193

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Nov 19, 2015

Okay, I subscribe as well, also would love to use much faster new jw player 7 :-)

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Nov 19, 2015

they say they "rewrote the player from gound up" and although everyone likes to claim that, if true, I understand it may be quite some work for Jason to look through their code again.
Nonetheless, allegedly v7 is much better. Urgently needed: the integration of s2m with v6 with s3 with CF is VERY SLOW and many interruptions...

@patdumond

This comment has been minimized.

patdumond commented Jan 20, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented Feb 12, 2016

@renzms

This comment has been minimized.

Contributor

renzms commented May 23, 2016

@kristineds

This comment has been minimized.

Contributor

kristineds commented Jun 30, 2016

Reference in internal private ticket: https://websharks.zendesk.com/agent/tickets/12830

@carfis

This comment has been minimized.

carfis commented Jun 30, 2016

Hi guys,
I have problem with the jwplayer 7 and the integration with S3. I can run the videos with the download-modus without issues (with multiples video qualities too) , but with the rtmp doesn't work. For that we need a manifesto file like "smil" in case of rtmp or "m3u8" for hls. those files have a crossdomain and need signed cookies.

"Error setting up player: Missing license key".

You can use this WordPress function to add the license key (needs min. WordPress 4.5.0):
wp_enqueue_script('jwplayer', get_bloginfo('url').'/jwplayer/jwplayer.js', array('jquery'), false, false);
wp_add_inline_script('jwplayer', 'jwplayer.key="YourLicenseKey";');

@renzms: Maybe you can use this in the shortcode.

@jaswrks jaswrks added this to the Next Release milestone Aug 30, 2016

@stellarman32

This comment has been minimized.

stellarman32 commented Aug 31, 2016

hi i am having issues with S2member's shortcodes not working with the new jwplayer 7 because it is still using the jw player 6. Any resolution to this?

@raamdev raamdev modified the milestones: Next Release, Future Release Oct 12, 2016

@raamdev raamdev modified the milestones: Next Release, Future Release Jan 21, 2017

jaswrks pushed a commit that referenced this issue Jan 23, 2017

jaswsinc

@jaswrks jaswrks modified the milestones: Next Release, Future Release Jan 24, 2017

@renzms

This comment has been minimized.

Contributor

renzms commented Jan 27, 2017

@jaswsinc

Possible Bug

Tested using:

WordPress Version: 4.7.2
Current WordPress Theme: Twenty Seventeen version 1.1
Theme Author: the WordPress team - https://wordpress.org/
Theme URI: https://wordpress.org/themes/twentyseventeen/
Active Plugins: s2Member Pro v170126-RC
PHP Version: 7.0.10-2+deb.sury.org~xenial+1
MySQL Version: 10.0.29-MariaDB-0ubuntu0.16.04.1
AWS S3 Bucket
JWPlayer v 7.8.7

Observed Behaviour

After filling up the Amazon S3 Panel in s2Member with appropriate details, and uploading the files to both the root and Amazon S3 for testing, the files do not stream properly:

screen shot 2017-01-28 at 12 49 35 am

Used the following codes, (Player Key and actual file paths have been edited)

RMTP


[s2Stream player="jwplayer-v7-rtmp-only" player_path="jwplayer/jwplayer.js" player_key="***************"  file_download="/s2stream.mp4" /]

via Rewrite URLS

[s2Stream player="jwplayer-v7" player_path="jwplayer/jwplayer.js" player_key="***************" file_download="/s2stream.mp4" rewrite="yes" /]

Could you please test also? Maybe there's something wrong with my configuration?

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 27, 2017

@renzms writes...

and uploading the files to both the root and Amazon S3 for testing

You don't mean the local root web directory, do you? As per the [s2Stream /] Shortcode Documentation:

  • file_download="video.mp4" Required. This is the location of the audio/video file, relative to the /s2member-files/ directory. Or, relative to the root of your Amazon S3 Bucket, when applicable.

So you should be uploading it wp-content/plugins/s2member-files/ for local testing, not your root web directory.

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 28, 2017

I also ran some tests and was unable to get JWPlayer 7 support working via the [s2Stream /] shortcode. After setting up Amazon S3/CloudFront, I confirmed that was working by creating the following URL to my video and successfully accessing the video via CloudFront:

/?s2member_file_download=tomandjerr_mTYbwoFu.mp4&s2member_file_inline=yes&s2member_skip_confirmation

I then tried playing that video via the [s2Stream /] shortcode using the following shortcode:

[s2Stream player="jwplayer-v7-rtmp-only" player_path="/jwplayer/jwplayer.js" player_key="XXXXXXXXXXXXXX" player_primary="html5" download_key="universal" file_download="tomandjerr_mTYbwoFu.mp4" /]

Instead of seeing an HTML5 player playing the video, I got the following (which mentions Flash and seems wrong given that I specified primary_player="html5"):

2017-01-27_21-36-52


@jaswsinc Any suggestions for us? I'd love to get the [s2Stream /] shortcode working with JWPlayer 7. :-)

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 31, 2017

Thank you for the testing! I actually have not tested this myself yet at all. So I'm sorry that you spent time working this only to find it was broken. I have this on my list for today and I will report back just as soon as I have determined what didn't come out right in my last round of changes to JW Player.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 31, 2017

@raamdev writes...

Instead of seeing an HTML5 player playing the video, I got the following (which mentions Flash and seems wrong given that I specified primary_player="html5")

The player in your shortcode is set to the RTMP-only variation, which means that Flash is required and JW Player will ignore the primary directive due to RTMP requiring Flash.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Jan 31, 2017

Hmm. I just ran a few tests and this seems to be working as expected on my side.
See: https://jason.wpsharks.net/jw-player-v7-test/

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Jan 31, 2017

@renzms

This comment has been minimized.

Contributor

renzms commented Jan 31, 2017

@jaswsinc @raamdev

I got this working after adding download_key="universal" manually to the short code and double checking my player_key as well as my S3 configurations.

screen shot 2017-01-31 at 10 33 47 pm

@RealDavidoff

This comment has been minimized.

RealDavidoff commented Jan 31, 2017

@raamdev

This comment has been minimized.

Contributor

raamdev commented Jan 31, 2017

Confirmed. It's working for me now too. I think I had a combination of browser / Flash issues. Testing in Chrome with RTMP-only (which forces Flash) doesn't seem to work for me (possibly because I have "click-to-run" Flash configured in my browser), however in Safari it works fine in all scenarios.

@jaswrks

This comment has been minimized.

Member

jaswrks commented Feb 1, 2017

Awesome! Thank you @RealDavidoff @renzms @raamdev for your help testing this. Mucho appreciated guys. This is one of those time-consuming test items. So your help was really fantastic.

@RealDavidoff I think at first you caught me right after I posted that test page. I came and posted the link and then suddenly realized that I forgot to remove restrictions from the videos so that all could see them. I fixed that about 30 seconds later, but it looks like you scored a 9.9/10 on the attention scale. ha.. Thank you again!

@raamdev raamdev removed the needs research label Feb 1, 2017

@renzms

This comment has been minimized.

Contributor

renzms commented Feb 2, 2017

@raamdev @jaswsinc

Confirming [s2Stream /] as working with JW Player 7 + S3 for RTMP, and other variations. 👍

@raamdev

This comment has been minimized.

Contributor

raamdev commented Feb 21, 2017

s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#774).

@raamdev raamdev closed this Feb 21, 2017

@websharks websharks locked and limited conversation to collaborators Feb 21, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.