-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: JW Player v7 Compatibility Issue #774
Comments
Okay, I subscribe as well, also would love to use much faster new jw player 7 :-) |
they say they "rewrote the player from gound up" and although everyone likes to claim that, if true, I understand it may be quite some work for Jason to look through their code again. |
Related internal ticket: https://websharks.zendesk.com/agent/tickets/10663. |
referencing internal ticket: https://websharks.zendesk.com/agent/tickets/11072 |
referencing internal ticket: https://websharks.zendesk.com/agent/tickets/12724 |
Reference in internal private ticket: https://websharks.zendesk.com/agent/tickets/12830 |
Hi guys,
You can use this WordPress function to add the license key (needs min. WordPress 4.5.0): @renzms: Maybe you can use this in the shortcode. |
hi i am having issues with S2member's shortcodes not working with the new jwplayer 7 because it is still using the jw player 6. Any resolution to this? |
@jaswsinc Possible BugTested using: WordPress Version: 4.7.2 Observed Behaviour After filling up the Amazon S3 Panel in s2Member with appropriate details, and uploading the files to both the root and Amazon S3 for testing, the files do not stream properly: Used the following codes, (Player Key and actual file paths have been edited) RMTP
via Rewrite URLS
Could you please test also? Maybe there's something wrong with my configuration? |
@renzms writes...
You don't mean the local root web directory, do you? As per the [s2Stream /] Shortcode Documentation:
So you should be uploading it |
I also ran some tests and was unable to get JWPlayer 7 support working via the
I then tried playing that video via the
Instead of seeing an HTML5 player playing the video, I got the following (which mentions Flash and seems wrong given that I specified @jaswsinc Any suggestions for us? I'd love to get the |
Thank you for the testing! I actually have not tested this myself yet at all. So I'm sorry that you spent time working this only to find it was broken. I have this on my list for today and I will report back just as soon as I have determined what didn't come out right in my last round of changes to JW Player. |
@raamdev writes...
The player in your shortcode is set to the RTMP-only variation, which means that Flash is required and JW Player will ignore the |
Hmm. I just ran a few tests and this seems to be working as expected on my side. |
Sorry to chime in here, maybe it helps: No, then it doesn't work, cause I
am seeing
"Error loading Player, no playable sources found"
:-)
…On 31 January 2017 at 05:33, jaswsinc ***@***.***> wrote:
Hmm. I just ran a few tests and this seems to be working as expected on my
side.
See: https://jason.wpsharks.net/jw-player-v7-test/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#774 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALPizN0iEA51tSSNH39H8TXODKSLbS7rks5rXseqgaJpZM4Ga53v>
.
|
@jaswsinc @raamdev I got this working after adding |
confirmed!
…On 31 January 2017 at 14:34, renzms ***@***.***> wrote:
@jaswsinc <https://github.com/jaswsinc> @raamdev
<https://github.com/raamdev>
I got this working after adding download_key="universal" to the short
code .
[image: screen shot 2017-01-31 at 10 33 47 pm]
<https://cloud.githubusercontent.com/assets/13220018/22469003/72ea0cf2-e805-11e6-854f-288ec5e4e6cf.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#774 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALPizOagDgdzgANaZo8quKDS1wIsoYZhks5rX0aLgaJpZM4Ga53v>
.
|
Confirmed. It's working for me now too. I think I had a combination of browser / Flash issues. Testing in Chrome with RTMP-only (which forces Flash) doesn't seem to work for me (possibly because I have "click-to-run" Flash configured in my browser), however in Safari it works fine in all scenarios. |
Awesome! Thank you @RealDavidoff @renzms @raamdev for your help testing this. Mucho appreciated guys. This is one of those time-consuming test items. So your help was really fantastic. @RealDavidoff I think at first you caught me right after I posted that test page. I came and posted the link and then suddenly realized that I forgot to remove restrictions from the videos so that all could see them. I fixed that about 30 seconds later, but it looks like you scored a 9.9/10 on the attention scale. ha.. Thank you again! |
@raamdev @jaswsinc Confirming
|
s2Member v170221 has been released and includes changes from this GitHub Issue. See the v170221 announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#774). |
Overview
We want to make JW Player v7 compatible with s2member. There is an error message after trying to upload files and use JW Player v7 with s2member. JW Player v7 is not yet compatible with s2Member as all of the code samples and
[s2Stream/]
shortcode are intended for JW Player v6.Steps to Reproduce
Expected Behavior
Files will play normally via JW Player.
Observed Behavior
Error message prompt.
When uploading files to website, message prompts: "Error setting up player: Missing license key".
Temporary Fix
Please revert JW Player to v6 to correct this error.
referenced in internal ticket: https://websharks.zendesk.com/agent/tickets/9193
The text was updated successfully, but these errors were encountered: