New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of "preg_replace() /e modifier" error still happening in version 151210 #811

Closed
nerdworker opened this Issue Dec 11, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@nerdworker

nerdworker commented Dec 11, 2015

We have the latest version installed and are still getting the Use of "preg_replace() /e modifier" error. A quick check of the sc-paypal-button-e.inc.php file on line 80 shows that the /e modifier still exists.

We are using PHP 7.

$code = preg_replace ("/(\<input)([^\>]+)(\>)/ie", "'\\1'.rtrim(stripslashes('\\2'),'/').' /\\3'", $code); // Use XHTML!

@jaswrks jaswrks added the bug label Dec 12, 2015

@jaswrks jaswrks added this to the Next Release milestone Dec 12, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 12, 2015

Thanks for reporting this! We will put a high priority on this for the next release.

@jaswrks jaswrks self-assigned this Dec 18, 2015

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue Dec 18, 2015

@jaswrks jaswrks referenced this issue Dec 18, 2015

Merged

PR: feature/811 #111

jaswrks pushed a commit that referenced this issue Dec 18, 2015

@jaswrks jaswrks referenced this issue Dec 18, 2015

Merged

PR: feature/811 #823

jaswrks pushed a commit that referenced this issue Dec 18, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 18, 2015

Next Release Changelog:

  • (s2Member) PHP v7 Compat.: This release addresses one remaining issue with the preg_replace /e modifier as reported in this GitHub issue. Props @nerdworker for reporting. Thanks!

@jaswrks jaswrks closed this Dec 18, 2015

@jaswrks

This comment has been minimized.

Member

jaswrks commented Dec 18, 2015

Work from this issue was pushed out with the release of s2Member v151218.
See: http://s2member.com/changelog/ for full details.

Future comments on this issue will now be blocked. If you have any trouble please open a new issue and report it. A big thanks to all of our great supporters. Happy Holidays :-) ❄️

@websharks websharks locked and limited conversation to collaborators Dec 18, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.