Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification Problem with CSS Pseudo-Classes #544

Closed
patdumond opened this issue Aug 12, 2015 · 2 comments
Closed

Minification Problem with CSS Pseudo-Classes #544

patdumond opened this issue Aug 12, 2015 · 2 comments

Comments

@patdumond
Copy link

Reference: https://webshark.zendesk.com/agent/tickets/7790

CSS pseudo-classes require a space between the class-name and pseudo-class-name. When minifying CSS with ZenCache, that space is removed, breaking the code.

For example:

.test :first-child { color: green; } would be changed to .test:first-child{color:green;}

Work-Around to Avoid This Issue

To avoid this issue, choose "No, do not compress the code in any unified CSS files" from the panel at WordPress Dashboard → ZenCache → Plugin Options → HTML Compression.

zencache-screenshot

@raamdev
Copy link
Contributor

raamdev commented Sep 3, 2015

Next Pro Release Changelog:

  • Bug Fix: Fixed an HTML Compressor bug related to CSS pseudo-classes where spaces between the class name and pseudo-class name were being removed when CSS was minified. Props @patdumond @jaswsinc. See Issue #544.

@raamdev
Copy link
Contributor

raamdev commented Oct 2, 2015

ZenCache Pro v151002 has been released and includes changes from this GitHub Issue.

See the ZenCache Pro v151002 release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#544).

@wpsharks wpsharks locked and limited conversation to collaborators Oct 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants