#164 added alignment config option for level item component #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public String getAlignment() { | ||
| if (alignment.equals("is-left")) { | ||
| return "is-justify-content-flex-start"; |
There was a problem hiding this comment.
Would it work for a more complex structure? I mean we could put a container to the level item and some contents inside the container. I think we have to use has-text-left/center/right? And by default we should use has-text-left
There was a problem hiding this comment.
I had same question in my head.. Rest changes look good
There was a problem hiding this comment.
Or maybe we need both classes?
There was a problem hiding this comment.
I think we need both classes. I updated the code.
paweljozwicki
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added alignment config option for author.
Motivation and Context
#164
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
bugenhancementChecklist: