Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOS-176 added container style config to navbar component #182

Merged
merged 5 commits into from
May 4, 2023

Conversation

Rafal-DS
Copy link
Contributor

@Rafal-DS Rafal-DS commented May 2, 2023

Description

Motivation and Context

Screenshots (if appropriate)

Upgrade notes (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue) labeled with bug
  • New feature (non-breaking change which adds functionality) labeled with enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code standards of this project.
  • My change requires updating the documentation. I have updated the documentation accordingly.

@@ -17,7 +17,7 @@
*/-->

<sly data-sly-use.model="pl.ds.bulma.components.models.navbar.NavbarComponent">
<sly data-sly-set.classes="navbar ${model.navbarStyle}"></sly>
<sly data-sly-set.classes="navbar ${model.navbarStyle} ${model.containerStyle}"></sly>
Copy link
Member

@paweljozwicki paweljozwicki May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an additional <div class="container ${model.containerStyle}"> below <nav>

Base automatically changed from WOS-173-apps-to-libs to develop May 4, 2023 07:47
@Rafal-DS Rafal-DS merged commit f1cc9d9 into develop May 4, 2023
2 checks passed
@Rafal-DS Rafal-DS deleted the WOS-176-navbar-container-style-config branch May 4, 2023 07:55
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants