Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _.extend usage issue, which override defaults data #6

Merged
merged 2 commits into from
Apr 27, 2015
Merged

Conversation

aivus
Copy link
Member

@aivus aivus commented Apr 27, 2015

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.38% when pulling 181a4d8 on fix-extend into 4550815 on master.

@s0ph1e
Copy link
Member

s0ph1e commented Apr 27, 2015

Thanks 👍
Can you also fix same issues in tests?

@aivus
Copy link
Member Author

aivus commented Apr 27, 2015

Yeap. Already fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.38% when pulling 4f4544c on fix-extend into 4550815 on master.

@s0ph1e
Copy link
Member

s0ph1e commented Apr 27, 2015

I think it would be better to pass params directly to function, without extends.
Something like

scraper.scrape({
    url: 'http://example.com',
    directory: '/dir',
    .....
})

@s0ph1e
Copy link
Member

s0ph1e commented Apr 27, 2015

@aivus what do you think?

@aivus
Copy link
Member Author

aivus commented Apr 27, 2015

I think we should leave defaultOptions like now. In the future, we can add to it required options.

s0ph1e added a commit that referenced this pull request Apr 27, 2015
Fix _.extend usage issue, which override defaults data
@s0ph1e s0ph1e merged commit be96e91 into master Apr 27, 2015
@aivus aivus deleted the fix-extend branch April 28, 2015 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants