Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use os.urandom() for cryptographically-secure random bytes #210

Closed
obi1kenobi opened this issue Sep 21, 2015 · 2 comments
Closed

Use os.urandom() for cryptographically-secure random bytes #210

obi1kenobi opened this issue Sep 21, 2015 · 2 comments

Comments

@obi1kenobi
Copy link
Contributor

The creation of a websocket 16-byte nonce for the initial handshake is done through a uuid.uuid4() call, which is not intended for generating unpredictable bytes for security or crypto purposes. Please use os.urandom() with 16 bytes of random data, because it is explicitly intended for such use.
@obi1kenobi obi1kenobi mentioned this issue Sep 21, 2015
Merged
liris added a commit that referenced this issue Oct 27, 2015
@liris
refs #211, #209, #210
c1aade5
@liris
Copy link
Collaborator

liris commented Oct 27, 2015

I've merged PR

@liris liris closed this as completed Oct 27, 2015
@obi1kenobi
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liris @obi1kenobi