-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl dependency conflics breaks build #54
Comments
Are you building off |
Using cargo, so building from crates.io. |
Same distro and same error here. According to cargo.lock file: For reference: |
also had the same dunno if you want to do that though.. |
Yeah this lib has needed to lock down its versions for a while, although I would rather try to target the most recent version. Haven't had a chance to look into this issue deeply just yet. |
This is because hyper depends on openssl 0.6.4 and websocket on 0.7.0. Either hyper needs to depend on 0.7.0 or websocket on 0.6.4. |
Yeah, until hyper is updated to use 0.7.0, our only choice really is to use 0.6.4. |
The original comment says it works with 0.6.7 as well. Is it possible to pick whichever one works and push a new release to crates.io? |
I messed around a bit with hyper, and it needs to upgrade it's version of "cookie" as cookie has the same dependency. Unfortunately some cookie related tests fail if I try that locally, so it's not entirely trivial to bump the openssl version. |
I suppose that one possible (though not ideal?) would be to drop the dependency on websocket, since it would be pulled in by hyper anyway. That would "automatically" made the libs sync. It's worth noting that the openssl dep is optional though for hyper. |
I believe this is now fixed, although I'm still wondering if there's a better way to avoid the version conflict. I'm quite tempted to try to actually remove hyper from the library and use httparse only, but that'd probably be quite difficult to do. |
@cyderize I am already in the midst of doing this on my fork (although using |
@illegalprime I'm not sure which would be more suitable (my suspicion is that it probably doesn't really matter). I was thinking of |
My local build fails with:
native library
openssl
is being linked to by more than one package, and can only be linked to by one packageopenssl-sys v0.7.0
openssl-sys v0.6.7
Hacking the library to depend on 0.6.7 fixes the build, for now at least.
The text was updated successfully, but these errors were encountered: