Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prebuilt artifacts #154

Closed
sroussey opened this issue Jan 7, 2024 · 1 comment
Closed

prebuilt artifacts #154

sroussey opened this issue Jan 7, 2024 · 1 comment

Comments

@sroussey
Copy link

sroussey commented Jan 7, 2024

I found this project to be a good example of how to do pre-built binaries for a node project. I am helping another project do this and while working on it I noticed some things that apparently don't affect you (yet) but may in the future.

Specifically, when you upload artifacts in the latest version, it does not let you reuse the name. This impacts windows-latest which you currently have both the i32 and x64 inside. I think it is v4 that disallows this.

I fixed this by adding the arch to the name

    - uses: actions/upload-artifact@v4
       with:
          name: ${{ matrix.os }}-${{ matrix.arch }}
          path: prebuilds
          retention-days: 1

You will want to account for that change where you tar things up as well.

@lpinca
Copy link
Member

lpinca commented Jan 13, 2024

You are right. It is documented here https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md. Thank you.

@lpinca lpinca closed this as completed in 331e278 Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants