[major] Drop support for the memLevel and level options

websockets · Jul 7, 2018 · 80e2002 · 80e2002
1 parent 92d0a2e
commit 80e2002
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/lib/permessage-deflate.js b/lib/permessage-deflate.js
@@ -413,15 +413,7 @@ class PerMessageDeflate {
         : this.params[key];
 
       this._deflate = zlib.createDeflateRaw(
-        Object.assign(
-          // TODO deprecate memLevel/level and recommend zlibDeflateOptions instead
-          {
-            memLevel: this._options.memLevel,
-            level: this._options.level
-          },
-          this._options.zlibDeflateOptions,
-          { windowBits }
-        )
+        Object.assign({}, this._options.zlibDeflateOptions, { windowBits })
       );
 
       this._deflate[kTotalLength] = 0;

diff --git a/test/permessage-deflate.test.js b/test/permessage-deflate.test.js
@@ -349,8 +349,14 @@ describe('PerMessageDeflate', function () {
     });
 
     it('honors the `level` option', function (done) {
-      const lev0 = new PerMessageDeflate({ threshold: 0, level: 0 });
-      const lev9 = new PerMessageDeflate({ threshold: 0, level: 9 });
+      const lev0 = new PerMessageDeflate({
+        threshold: 0,
+        zlibDeflateOptions: { level: 0 }
+      });
+      const lev9 = new PerMessageDeflate({
+        threshold: 0,
+        zlibDeflateOptions: { level: 9 }
+      });
       const extensionStr = (
         'permessage-deflate; server_no_context_takeover; ' +
         'client_no_context_takeover; server_max_window_bits=10; ' +
@@ -409,7 +415,8 @@ describe('PerMessageDeflate', function () {
         }
       });
 
-      // Note no context takeover so we can get a hold of the raw streams after we do the dance
+      // Note no context takeover so we can get a hold of the raw streams after
+      // we do the dance.
       const extensionStr = (
         'permessage-deflate; server_max_window_bits=10; ' +
         'client_max_window_bits=11'