Remove the flags argument
#1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flags` object specifies whether the received data is binary or not and whether it was masked or not. This object is actually redundant and therefore removed in this commit as the spec requires client-sent frames to be masked and server-sent frame to be unmasked. The `typeof` operator can be used to check whether the received data is binary or not.
|
+1 for the sake of API consistency. |
3rd-Eden
approved these changes
May 11, 2017
lpinca
added a commit
that referenced
this pull request
May 16, 2017
The `flags` object specifies whether the received data is binary or not and whether it was masked or not. This object is actually redundant and therefore removed in this commit as the spec requires client-sent frames to be masked and server-sent frame to be unmasked. The `typeof` operator can be used to check whether the received data is binary or not.
lpinca
added a commit
that referenced
this pull request
May 16, 2017
The `flags` object specifies whether the received data is binary or not and whether it was masked or not. This object is actually redundant and therefore removed in this commit as the spec requires client-sent frames to be masked and server-sent frame to be unmasked. The `typeof` operator can be used to check whether the received data is binary or not.
lpinca
added a commit
that referenced
this pull request
May 17, 2017
The `flags` object specifies whether the received data is binary or not and whether it was masked or not. This object is actually redundant and therefore removed in this commit as the spec requires client-sent frames to be masked and server-sent frame to be unmasked. The `typeof` operator can be used to check whether the received data is binary or not.
|
|
|
@rimmartin if it's not a string and you use default settings it's a |
|
@lpinca ah thanks |
facebook-github-bot
pushed a commit
to facebookarchive/nuclide
that referenced
this pull request
Oct 14, 2017
Summary: Address the breaking changes from: https://github.com/websockets/ws/releases/tag/3.0.0 Apply the changes suggested in websockets/ws#1099 Apply the changes suggested in websockets/ws#1101 Reviewed By: hansonw Differential Revision: D6031593 fbshipit-source-id: 6ffe8b03dd6ddab1dc26074a5d9b3baf55689d17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
flagsobject specifies whether the received data is binary or not and whether it was masked or not. This object is actually redundant and therefore removed in this commit as the spec requires client-sent frames to be masked and server-sent frame to be unmasked.The
typeofoperator can be used to check whether the received data is binary or not.