Tip for other people in documentation #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Oct 7, 2018
README.md
Outdated
| @@ -112,7 +112,7 @@ const wss = new WebSocket.Server({ | |||
| // Other options settable: | |||
| clientNoContextTakeover: true, // Defaults to negotiated value. | |||
| serverNoContextTakeover: true, // Defaults to negotiated value. | |||
| clientMaxWindowBits: 10, // Defaults to negotiated value. | |||
| clientMaxWindowBits: 10, // Defaults to negotiated value. Right now, setting this causes conection to fail in FF. | |||
There was a problem hiding this comment.
I think it's better to completely remove clientMaxWindowBits from the example. There is nothing wrong with FF, it's the configuration that makes the offer sent by FF unacceptable.
We already have this sentence "See docs for more options." before the example so that should be sufficient.
There was a problem hiding this comment.
i agree removing is better.
|
Did you close this by mistake? You can update this PR if you want. |
|
updated it |
lpinca
approved these changes
Oct 7, 2018
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.