Fix "zlib binding closed" errors

[darrachequesne]

This should fix #628, which I think is caused by:

• deflate is closed
• deflate.write() then triggers an 'error' event
• cleanup() removes the listener attached to the 'error' event
• deflate.flush() triggers the uncaught error 'zlib binding closed'

Does this make any sense?

[nkzawa]

👍 It might be better to add a guard to compress and decompress for checking if the instance is already cleaned up, like https://github.com/websockets/ws/blob/master/lib/Receiver.js#L269 .

[DanReyLop]

I don't know this codebase, but... I think this means that if there is an _inflate.writeInProgress when the connection is closed, the _deflate will never be closed. Instead of returning, this should be rewritten as:

if (this._inflate.writeInProgress) {
      this._inflate.pendingClose = true;
} else {
      if (this._inflate.close) this._inflate.close();
     this._inflate = null;
}

[darrachequesne]

You're absolutely right! I'll patch this.

[rauchg]

👍

Tested & works perfectly. No more

node: ../src/node_zlib.cc:132: static v8::Handle<v8::Value> node::ZCtx::Write(const v8::Arguments&): Assertion `!ctx->pending_close_ && "close is pending"' failed.
Aborted (core dumped)

[3rd-Eden]

Adressing this tomorrow

Arnout Kazemier

On Dec 20, 2015, at 5:43 PM, Guillermo Rauch notifications@github.com wrote:

Tested & works perfectly. No more

node: ../src/node_zlib.cc:132: static v8::Handlev8::Value node::ZCtx::Write(const v8::Arguments&): Assertion `!ctx->pending_close_ && "close is pending"' failed.
Aborted (core dumped)
—
Reply to this email directly or view it on GitHub.

[darrachequesne]

Thanks! That should fix #633 too.

[darrachequesne]

Hi! @3rd-Eden could you please release this as version 0.8.2 before the big 1.0? 🙏 (the current 0.8.1 is not really usable due to that issue).

[3rd-Eden]

Release of 1.0 goes out tomorrow. No 0.8.2 -- if you have issues, turning off deflate by default

Arnout Kazemier

On Dec 22, 2015, at 6:33 PM, Damien Arrachequesne notifications@github.com wrote:

Hi! @3rd-Eden could you please release this as version 0.8.2 before the big 1.0? (the current 0.8.1 is not really usable due to that issue).

—
Reply to this email directly or view it on GitHub.