Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix: shrinkStrategy should always return an integer #645
Conversation
dignifiedquire
referenced this pull request
Dec 27, 2015
Closed
Karma chrashes with: Fatal error: Wrong length [0.13.16 regression] #1768
This comment has been minimized.
This comment has been minimized.
egoroof
commented
Dec 27, 2015
|
|
1 similar comment
This comment has been minimized.
This comment has been minimized.
neoziro
commented
Dec 28, 2015
|
|
added a commit
that referenced
this pull request
Dec 28, 2015
3rd-Eden
merged commit c7c8172
into
websockets:master
Dec 28, 2015
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
|
dignifiedquire
deleted the
dignifiedquire:buffer-length
branch
Dec 28, 2015
DevVersion
referenced this pull request
Dec 28, 2015
Closed
feat(list): add support for md-menu as proxied element #6459
This comment has been minimized.
This comment has been minimized.
diwu1989
commented
Dec 28, 2015
|
can you make a release? we really need this for Karma to work |
This comment has been minimized.
This comment has been minimized.
DevVersion
commented
Dec 30, 2015
|
Yes, that's really important Edit: Seem's to be there is a new release deployed |
zloirock
referenced this pull request
Jan 3, 2016
Closed
ArrayBuffer() & ArrayBuffer("some non-number") doesn't match implementations #265
added a commit
to zloirock/core-js
that referenced
this pull request
Jan 3, 2016
zloirock
referenced this pull request
Mar 29, 2016
Merged
Normalize TypedArray, ArrayBuffer and DataView constructors #410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dignifiedquire commentedDec 27, 2015
Bufferinherits fromUint8Arryso the constructor needs to becalled with integers and mustn't be called with floats.
This patch ensures that the result of the the calculation
in the
shrinkStrategyinReceiverreturns an integer.The reason why this has not been a problem up to now is that
a there is a V8 Bug
that the spec
is not adhered in this case.
This is a blocking issue for Karma
as the upgrade to core-js@2.0.0
now enforces this error.