Fix for #680 (https://github.com/websockets/ws/issues/680) #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @3rd-Eden |
Closed
|
works for me! |
|
Can we please have this accepted? |
|
pretty please! |
|
Lol! cc @3rd-Eden |
|
Accept this plz IT WORKS! , can som1 explain why people here don't fucking accept PRs that work 100%,, I just dont get it and I love to make PRs but people just dont even reply... :( |
|
@hassanila97 because we have private life as well. |
|
@3rd-Eden I know but this lasted 1 month and it was fully working... with noone reporting any bug.. |
|
@hassanila97 sorry about the delay, don't be angry. It will probably get accepted in the next update cycle, besides you can use the PR while waiting. |
|
Yeah thx |
|
Thanks for your contribution! |
|
Glad to help!! |
|
Can i ask when NPM package will be updated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #680 cc @rkaw92, test added.