Improve performance of fallback mask and unmask functions #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Oct 12, 2016
| }, | ||
| unmask: function(data, mask) { | ||
| var maskNum = mask.readUInt32LE(0, true); | ||
| var length = data.length; |
There was a problem hiding this comment.
@Nibbler999 can you use data.length directly in the for loop? This variable is not very useful.
There was a problem hiding this comment.
It's there because of a regression in node I encountered when working on this - nodejs/node#9006
There was a problem hiding this comment.
Maybe add a "remove when fixed" comment?
|
Apart from the comment above (add a reference to the node issue) this LGTM, big +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple implementation seems to be significantly faster in all benchmarks. Am I missing something?