New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addexecute #58
Addexecute #58
Conversation
sorry for the opening and closing... :) |
I'm not experiencing the behavior you describe in #45 (comment) when I use Other than that, the execute option looks good. |
Oh, also, please clean up the whitespace to be consistent with the rest of the code. Spaces around |
I will clean up the code. |
OK, I tested the master and it is working. Learned something new... I have reverted my changes regarding |
#41 is probably a cleaner approach to the same problem. |
I tried to pipe, but in my case the connection was closed immediately, and I needed a way to send the command after the connection had been established. Here an example using the current master:
Here an example using the wscat that includes the
In both cases the query string was echo'd before the connection was properly established. The Also, when using |
We should probably rewrite the module, use streams and simplify everything. I like what @jnordberg did in I'll leave this to @nwwells. |
#41 apparently doesn't work. Not sure how it could, tbh. I'm not wild about the interface, but we need to refactor loads of stuff anyway. For starters, using stdin should be the default. and you should close the connection on |
This addresses two issues: