Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor link behaviour in preview #1237

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Refactor link behaviour in preview #1237

merged 4 commits into from
Mar 14, 2023

Conversation

rpominov
Copy link
Contributor

@rpominov rpominov commented Mar 14, 2023

Description

Steps for reproduction

  1. Open preview mode
  2. Click on some links

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
  • hi @TrySound, I need you to do
    • detailed review (read every line)

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Mar 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 10:51AM (UTC)

@rpominov rpominov merged commit 4b1a684 into main Mar 14, 2023
@rpominov rpominov deleted the preview-link branch March 14, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When in preview, external links should open in new window
3 participants