Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better instance outline #56

Closed
kof opened this issue May 31, 2022 · 2 comments
Closed

Better instance outline #56

kof opened this issue May 31, 2022 · 2 comments
Assignees
@kof
Labels
area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work type:bug Something isn't working

Comments

@kof
Copy link
Member

kof commented May 31, 2022

Current outline doesn't work well in multiple cases:

  • component is at the very top (tag gets cut off)
  • padding is used (tag shifts)

We need to render the outline outside of the component and detect components's position.
@kof kof added type:bug Something isn't working area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work labels May 31, 2022
@kof kof self-assigned this May 31, 2022
@kof kof linked a pull request Jun 5, 2022 that will close this issue
Better instance outline #57
Closed
@kof kof mentioned this issue Jun 5, 2022
Closed
@kof kof mentioned this issue Jun 13, 2022
Merged
@kof
Copy link
Member Author

kof commented Jun 16, 2022

tbc in #68

@kof kof closed this as completed Jun 16, 2022
@kof
Copy link
Member Author

kof commented Jun 16, 2022

will release together with #68, so its not on prod yet

@okonet okonet mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kof kof

Labels
area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work type:bug Something isn't working
Projects
No open projects
Webstudio Beta
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better instance outline webstudio-is/webstudio
1 participant
@kof