Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move content-editable toolbar to workspace-tools and replace content editor with lexical.dev #68

Closed
kof opened this issue Jun 15, 2022 · 3 comments
Assignees
Labels
area:canvas Anything related to rendering on canvas complexity:high Multiple weeks of work or more prio:1 The most important thing to work on type:feat Features and enhancements

Comments

@kof
Copy link
Member

kof commented Jun 15, 2022

Currently the toolbar is still inside the canvas/iframe and now we moved outlines into workspace tools and they get rendered on top of the text editing toolbar

image

@kof kof added type:bug Something isn't working area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work labels Jun 15, 2022
@kof kof self-assigned this Jun 15, 2022
@kof kof added the prio:1 The most important thing to work on label Jun 16, 2022
@kof kof changed the title Move content-editable toolbar to workspace-tools Move content-editable toolbar to workspace-tools and replace content editor with lexical from fb Jun 20, 2022
@okonet
Copy link
Contributor

okonet commented Jun 21, 2022

I'm thinking that in order to avoid all possible and uncovered edge cases like #77 we should not rely on content-editable at all. Instead, we could build a UI in the designer using the outline layer (since #56 is merged) and use props to pass down the children to components.

One gotcha could be, though, is modality of this UI but I think we could create a UX similar to content-editable although keeping it in a completely separate JS / DOM tree.

Additionally, I think it would be great to show children prop explicitly somehow in the advanced tab. This would solve two potential use cases: users can edit content in the side panel (consistently with styles), and it would allow editing non-children props like value in the <input type="button">.

WDYT?

@okonet
Copy link
Contributor

okonet commented Jun 21, 2022

You can take a look at https://docs.slatejs.org since its a similar abstraction like https://lexical.dev. But from my past experience https://prosemirror.net worked the best.

@kof kof added complexity:high Multiple weeks of work or more type:feat Features and enhancements area:designer and removed complexity:medium Up to 1 week of work type:bug Something isn't working labels Jun 22, 2022
@kof kof changed the title Move content-editable toolbar to workspace-tools and replace content editor with lexical from fb Move content-editable toolbar to workspace-tools and replace content editor with lexical.dev Jul 1, 2022
@kof
Copy link
Member Author

kof commented Jul 5, 2022

Follow up issue #107

@kof kof closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:canvas Anything related to rendering on canvas complexity:high Multiple weeks of work or more prio:1 The most important thing to work on type:feat Features and enhancements
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants