Use floating-ui to position text toolbar #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #107 Text toolbar is badly positioned when flipped up. Keeping it too close to cursor makes text selection harder. Here I replaced custom logic with computed rect from toolbar parent and state from canvas. A few middlewares polished offsets. Flip no longer overlap text. Also fixed toolbar background.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kof
reviewed
Nov 18, 2022
apps/designer/app/canvas/features/text-editor/toolbar-connector.tsx
Outdated
Show resolved
Hide resolved
kof
approved these changes
Nov 18, 2022
istarkov
reviewed
Nov 19, 2022
apps/designer/app/designer/features/workspace/canvas-tools/text-toolbar/text-toolbar.tsx
Outdated
Show resolved
Hide resolved
istarkov
reviewed
Nov 19, 2022
apps/designer/app/designer/features/workspace/canvas-tools/text-toolbar/text-toolbar.tsx
Outdated
Show resolved
Hide resolved
istarkov
reviewed
Nov 19, 2022
apps/designer/app/designer/features/workspace/canvas-tools/text-toolbar/text-toolbar.tsx
Outdated
Show resolved
Hide resolved
istarkov
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #107
Text toolbar is badly positioned when flipped up. Keeping it too close to cursor makes text selection harder.
Here I replaced custom logic with computed rect from toolbar parent and state from canvas. A few middlewares polished offsets. Flip no longer overlap text.
Also fixed toolbar background.
Before requesting a review
Test cases
Before merging
.env.exampleand thedesigner/env-check.jsif mandatory