Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text editor styling and enable auto focus #504

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Conversation

TrySound
Copy link
Member

Ref #107

  • fixed bold italic styling
  • populate default style for instances created from text editor
  • added unmount support to css engine
  • auto focus text editor when start editing

Before requesting a review

  • if the PR is WIP - use draft mode
  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")
  • what kind of review is needed?
    • conceptual
    • detailed
    • with testing

Test cases

  • step by step interaction description and what is expected to happen

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

Ref #107

- fixed bold italic styling
- populate default style for instances created from text editor
- added unmount support to css engine
- auto focus text editor when start editing
@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 5:05PM (UTC)

@TrySound TrySound merged commit 7f44d78 into main Nov 23, 2022
@TrySound TrySound deleted the text-editor-bugs branch November 23, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants