Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@type should be at top level of action #153

Closed
benfrancis opened this issue Jun 23, 2020 · 2 comments
Closed

@type should be at top level of action #153

benfrancis opened this issue Jun 23, 2020 · 2 comments
Assignees
@mrstegeman
Labels
bug

Comments

@benfrancis
Copy link
Member

In Example 8 the "@type": "FadeAction" should really be at the top level of the Action object rather than inside the input member, because the annotation applies to the action object and not the input. If there was an output member as well it would not have a separate @type.

Not sure what Mozilla WebThings implementations actually do here...
@benfrancis benfrancis added the bug label Jun 23, 2020
@mrstegeman mrstegeman self-assigned this Jun 23, 2020
@benfrancis
Copy link
Member Author

Thanks @mrstegeman ! I assume that this reflects what WebThings actually exposes?

@mrstegeman
Copy link
Contributor

Yes, it was just a textual issue in this one example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrstegeman mrstegeman

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrstegeman @benfrancis