Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken tests from #199. #200

Merged
merged 6 commits into from
Aug 4, 2019

Conversation

chr15m
Copy link
Contributor

@chr15m chr15m commented Jun 7, 2018

@chr15m
Copy link
Contributor Author

chr15m commented Jun 7, 2018

Note: we should remove test/put-get.js from this since it is superfluous (already covered by test/dht_store_mutable.js). I've left it in here for now to demonstrate that the error is with the tests not with the library.

@robertkowalski
Copy link
Contributor

thx! makes sense now.

@feross
Copy link
Member

feross commented Aug 4, 2019

Can someone explain the purpose of this PR? That would help me to review it. Thanks.

@chr15m
Copy link
Contributor Author

chr15m commented Aug 4, 2019

Hi @ferros - thanks for taking the time to review this patch.

It has been a while but after reviewing I think this patch just adds a test for mutable DHT put(), specifically with salt defined. Prior to this patch there is only a test for mutable put() with no salt.

See #190 for details of changes to mutable put() with salt which are covered by the test in this patch.

Copy link
Member

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for explaining @chr15m. Will merge it since the tests are passing :)

@feross feross merged commit e874b7b into webtorrent:master Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants