Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake/extended API issue #8

Closed
astro opened this issue Feb 20, 2015 · 2 comments
Closed

Handshake/extended API issue #8

astro opened this issue Feb 20, 2015 · 2 comments

Comments

@astro
Copy link
Contributor

astro commented Feb 20, 2015

In _onHandshake() we emit the 'handshake' event where we expect the handler to send with handshake() synchronously. If the handler defers handshaking the further body of _onHandshake() will send the extended() message before the actual protocol handshake(), which is a protocol violation.

Is this something you want to get sorted out? A deviation from the current assumptions about callers will probably break API compatibility.
@feross
Copy link
Member

feross commented Feb 20, 2015

Yep, confirmed. This issue hasn't affected webtorrent because we always call handshake() synchronously in the 'handshake' event handler. PR welcome.

astro added a commit that referenced this issue Feb 21, 2015
@astro
refactor into automatic sendExtendedHandshake() for async handshake r…
10b835a 
…esponse

see GH issue #8
@astro astro mentioned this issue Feb 21, 2015
Merged
@feross
Copy link
Member

feross commented Mar 10, 2015

Released as 1.5.6.

@feross feross closed this as completed Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astro @feross