Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on Travis #18

Closed
feross opened this issue May 17, 2014 · 1 comment
Closed

Tests fail on Travis #18

feross opened this issue May 17, 2014 · 1 comment

Comments

@feross
Copy link
Member

feross commented May 17, 2014

This is happening because the tests rely on connecting to external services and I think that Travis is getting rate-limited by the UDP tracker servers / they are blocking UDP traffic.

Once #9 is implemented, then we can change the tests to just use local tracker servers!
feross added a commit that referenced this issue May 24, 2014
@feross
make large torrent test not depend on the network
954b3af 
for #18
feross added a commit that referenced this issue May 24, 2014
@feross
make magnet test work offline
dc6f355 
for #18
feross added a commit that referenced this issue May 24, 2014
@feross
make client tests work offline
2aea063 
for #18
@feross feross closed this as completed in 62be689 May 24, 2014
@feross
Copy link
Member Author

feross commented May 24, 2014

This was a long time coming, but tests can now pass without an internet connection because this module contains a full http+udp tracker server implementation so we can test against ourselves.

This fixes the failing travis tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feross